[APM] Limit per_service query to transaction documents#143138
Merged
basepi merged 2 commits intoelastic:mainfrom Oct 11, 2022
Merged
[APM] Limit per_service query to transaction documents#143138basepi merged 2 commits intoelastic:mainfrom
basepi merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
sorenlouv
reviewed
Oct 11, 2022
| executor: async ({ indices, search }) => { | ||
| const response = await search({ | ||
| index: [indices.metric], | ||
| index: [indices.transaction], |
Contributor
There was a problem hiding this comment.
Transaction events are subject to sampling so the returned stats are not going to be accurate. If we are ok with that I don't have any objections.
Contributor
Author
There was a problem hiding this comment.
In this case we're not paying attention to any of the stats. We pretty much just query metadata from the transaction document, no counts or anything.
sorenlouv
approved these changes
Oct 11, 2022
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2022
(cherry picked from commit d260172)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
per_servicetelemetry task to only query transaction documents.This should solve the missing data issues around
service.frameworkand similar fields that aren't present on all documents.Checklist
No checklist items were applicable
For maintainers
Ref #137216