Skip to content

[Enterprise Search] Copy and doclink improvements for Index Pipeline settings#143112

Merged
byronhulcher merged 3 commits intoelastic:mainfrom
byronhulcher:pipeline-settings
Oct 11, 2022
Merged

[Enterprise Search] Copy and doclink improvements for Index Pipeline settings#143112
byronhulcher merged 3 commits intoelastic:mainfrom
byronhulcher:pipeline-settings

Conversation

@byronhulcher
Copy link
Copy Markdown
Contributor

@byronhulcher byronhulcher commented Oct 11, 2022

Summary

Checklist

Delete any items that are not applicable to this PR.

@byronhulcher byronhulcher self-assigned this Oct 11, 2022
@byronhulcher byronhulcher requested a review from a team as a code owner October 11, 2022 16:42
@byronhulcher byronhulcher requested review from a team and chriscressman October 11, 2022 16:42
@byronhulcher byronhulcher enabled auto-merge (squash) October 11, 2022 16:54
Copy link
Copy Markdown
Contributor

@chriscressman chriscressman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link changes look good. Thanks Byron!

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +263.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 367.2KB 367.2KB -57.0B
enterpriseSearch 28.0KB 27.9KB -129.0B
total -186.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following @chriscressman's lead, link changes look good.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 11, 2022
…settings (#143112) (#143118)

(cherry picked from commit db6daca)

Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants