Skip to content

[Data] [Search] postFlightRequest should accept disableShardFailureWarning param#143096

Merged
alexwizp merged 1 commit intoelastic:mainfrom
alexwizp:disableShardFailureWarning
Oct 12, 2022
Merged

[Data] [Search] postFlightRequest should accept disableShardFailureWarning param#143096
alexwizp merged 1 commit intoelastic:mainfrom
alexwizp:disableShardFailureWarning

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Oct 11, 2022 •
edited by kibanamachine
Loading

Summary

In order not to annoy the user with a large number of unnecessary notifications, we must pass the disableShardFailureWarning search option set in the parent context to thepostFlightRequest method

Before:

Screen.Recording.2022-10-11.at.18.09.17.mov

After:

image

@alexwizp alexwizp self-assigned this Oct 11, 2022
@alexwizp alexwizp added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.6.0 Feature:Search Querying infrastructure in Kibana backport:prev-minor labels Oct 11, 2022
@alexwizp alexwizp marked this pull request as ready for review October 11, 2022 15:15
@alexwizp alexwizp requested a review from a team as a code owner October 11, 2022 15:15
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 11, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Oct 11, 2022
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 11, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2515 2516 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 437.1KB 437.1KB +60.0B
Unknown metric groups

API count

id before after diff
data 3227 3228 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Oct 12, 2022

@elastic/kibana-app-services please have a look

Dosant
Dosant approved these changes Oct 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, didn't test cc @tsullivan

@alexwizp alexwizp merged commit e5cebd8 into elastic:main Oct 12, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 12, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2022
@alexwizp
[Data] [Search] postFlightRequest should accept `disableShardFailureW…
4bed622 
…arning` param (elastic#143096)

(cherry picked from commit e5cebd8)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 12, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 12, 2022
@kibanamachine @alexwizp
[Data] [Search] postFlightRequest should accept `disableShardFailureW…
24b33b6 
…arning` param (#143096) (#143172)

(cherry picked from commit e5cebd8)

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dosant Dosant Dosant approved these changes

Assignees

@alexwizp alexwizp

Labels

Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.5.0 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @elasticmachine @kibana-ci @kibanamachine @Dosant