Merged
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
tested via the cloud build and this looks ok to me. i'm going to let the env sit for a while and check it again, when it's rule counts have gotten up to 10k+ runs for now, screenshot from test cloud cluster: |
JiaweiWu
approved these changes
Oct 7, 2022
Contributor
JiaweiWu
left a comment
There was a problem hiding this comment.
LGTM! I'll test it a bit more next week but the code looks good
jcger
approved these changes
Oct 10, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2022
* add ordering + bigger bucket for the KPI * css cleanup (cherry picked from commit 2efcf7a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #142910
To resolve this problem, we are thinking about doing two thing:
We kind of worry about the memory when we changed the bucket to 10000. So we did some stats by using
Buffer.byteLength(JSON.stringify(results));. The results below:Bucket of 10000, we do have 5.9 Mb in memory of the node
Bucket of 5000, we do have 2.9Mb in memory of the node
Bucket of 1000, we do have 590 kb in memory of the node
Reviewer what do you think?
Checklist