[Security Solution][Endpoint] New API for creating a `get-file` response action request by paul-tavares · Pull Request #142671 · elastic/kibana

paul-tavares · 2022-10-04T21:05:56Z

Summary

Register a new POST api route at /api/endpoint/action/get_file to handle creating get-file action request
Some refactoring to move some const's to the actions service directory

Usage:

API usage below.

Request:

POST /api/endpoint/action/get_file
{
    "endpoint_ids": [
        "51af3cec-68a3-42c6-a623-1c95b4111453"
    ],
    "parameters": {
        "path": "/one/two/three"
    }
}

Response:

{
    "data": {
        "id": "271b0b13-9f30-4b1c-8c25-03e36267a4ca",
        "agents": [
            "51af3cec-68a3-42c6-a623-1c95b4111453"
        ],
        "hosts": {
            "51af3cec-68a3-42c6-a623-1c95b4111453": {
                "name": "Host-mtnj0uq155"
            }
        },
        "command": "get-file",
        "startedAt": "2022-10-04T21:12:52.572Z",
        "isCompleted": false,
        "wasSuccessful": false,
        "isExpired": false,
        "status": "pending",
        "outputs": {},
        "agentState": {
            "51af3cec-68a3-42c6-a623-1c95b4111453": {
                "isCompleted": false,
                "wasSuccessful": false
            }
        },
        "createdBy": "elastic",
        "parameters": {
            "path": "/one/two/three"
        }
    }
}

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…ile-action-request-api

…nt/service/response_actions/constants`

…tions

elasticmachine · 2022-10-05T16:26:16Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

…generator

…ile-action-request-api

paul-tavares · 2022-10-05T18:28:24Z

x-pack/plugins/security_solution/common/endpoint/constants.ts

-/**
- * The list of possible capabilities, reported by the endpoint in the metadata document
- */
-export const RESPONDER_CAPABILITIES = [


NOTE: most of the changes in this PR are a result of this refactor

ashokaditya

Looking good to 🚢 . I have a few suggestions that are not blockers.

Also this can be done in a new PR as this one is mostly API related changes, but we also need a pendingGetFile to EndpointHostIsolationStatus component

kibana/x-pack/plugins/security_solution/public/common/components/endpoint/host_isolation/endpoint_host_isolation_status.tsx

Line 15 in c05190e

export interface EndpointHostIsolationStatusProps {

and in

kibana/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/selectors.ts

Line 282 in c05190e

export const getEndpointHostIsolationStatusPropsCallback: (

for showing pending actions for get-file

...t/components/endpoint_response_actions_list/components/use_action_history_url_params.test.ts

x-pack/plugins/security_solution/common/endpoint/service/response_actions/constants.ts

...gement/components/endpoint_response_actions_list/components/use_action_history_url_params.ts

...ty_solution/public/management/components/endpoint_response_actions_list/components/hooks.tsx

x-pack/plugins/security_solution/common/endpoint/data_generators/endpoint_metadata_generator.ts

…ile-action-request-api

paul-tavares · 2022-10-11T13:04:51Z

Thanks @ashokaditya . I incorporated your changes and opened up an issue to track updating the endpoint_host_isolation_status.tsx component in a subsequent PR

…-ref HEAD~1..HEAD --fix'

kibana-ci · 2022-10-11T16:39:47Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.6MB	6.6MB	+131.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	411	410	-1

Total ESLint disabled count

id	before	after	diff
`securitySolution`	484	483	-1

History

💔 Build #79373 failed e5933fb
💚 Build #78496 succeeded b848352
💚 Build #78459 succeeded e5db448
💔 Build #78139 failed a5db442
💔 Build #78125 failed 2f69e64

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

legrego

Import reformatting in x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table.tsx LGTM

Register API for creating a get-file response action request

2f69e64

paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.6.0 labels Oct 4, 2022

paul-tavares self-assigned this Oct 4, 2022

paul-tavares added 6 commits October 4, 2022 17:36

Change command parameter to path instead of file

10d1eb6

add tests for new get-file request route

a5db442

Merge remote-tracking branch 'upstream/main' into task/olm-2477-get-f…

cda3a12

…ile-action-request-api

Moved some const from common/endpoint/constants to `common/endpoi…

9f67a78

…nt/service/response_actions/constants`

Renames Response Action const for clarity

0b47bc3

Changed useActionHistoryUrlParams() test to include all response ac…

e5db448

…tions

paul-tavares marked this pull request as ready for review October 5, 2022 16:24

paul-tavares requested review from a team as code owners October 5, 2022 16:24

paul-tavares requested review from ashokaditya and pzl October 5, 2022 16:24

paul-tavares added 2 commits October 5, 2022 14:08

Added get_file to endpoint capabilities and added support into the …

dbbac3d

…generator

Merge remote-tracking branch 'upstream/main' into task/olm-2477-get-f…

b848352

…ile-action-request-api

paul-tavares commented Oct 5, 2022

View reviewed changes

paul-tavares mentioned this pull request Oct 5, 2022

[Security Solution][Endpoint] Add get-file command to the Endpoint Response Console #142800

Closed

9 tasks

ashokaditya approved these changes Oct 6, 2022

View reviewed changes

pzl approved these changes Oct 10, 2022

View reviewed changes

paul-tavares added 2 commits October 11, 2022 08:51

Merge remote-tracking branch 'upstream/main' into task/olm-2477-get-f…

5c94daf

…ile-action-request-api

Adjusted types to use ConsoleResponseActionCommands

e5933fb

paul-tavares requested a review from ashokaditya October 11, 2022 13:04

ashokaditya approved these changes Oct 11, 2022

View reviewed changes

paul-tavares and others added 2 commits October 11, 2022 11:01

Merge branch 'main' into task/olm-2477-get-file-action-request-api

15900b0

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

60d43ad

…-ref HEAD~1..HEAD --fix'

kibanamachine requested a review from a team as a code owner October 11, 2022 15:08

legrego approved these changes Oct 11, 2022

View reviewed changes

paul-tavares merged commit b5bacc3 into elastic:main Oct 11, 2022

kibanamachine added the backport:skip This PR does not require backporting label Oct 11, 2022

paul-tavares deleted the task/olm-2477-get-file-action-request-api branch October 11, 2022 18:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] New API for creating a `get-file` response action request#142671

[Security Solution][Endpoint] New API for creating a `get-file` response action request#142671
paul-tavares merged 13 commits intoelastic:mainfrom
paul-tavares:task/olm-2477-get-file-action-request-api

paul-tavares commented Oct 4, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Oct 5, 2022

Uh oh!

paul-tavares Oct 5, 2022

Uh oh!

ashokaditya left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paul-tavares commented Oct 11, 2022

Uh oh!

kibana-ci commented Oct 11, 2022

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

legrego left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

paul-tavares commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Usage:

Request:

Response:

Checklist

Uh oh!

elasticmachine commented Oct 5, 2022

Uh oh!

paul-tavares Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paul-tavares commented Oct 11, 2022

Uh oh!

kibana-ci commented Oct 11, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

paul-tavares commented Oct 4, 2022 •

edited

Loading