Changed useActionHistoryUrlParams() test to include all response actions

paul-tavares · paul-tavares · commit e5db4482f7d9 · 2022-10-05T12:23:53.000-04:00
diff --git a/x-pack/plugins/security_solution/common/endpoint/service/response_actions/constants.ts b/x-pack/plugins/security_solution/common/endpoint/service/response_actions/constants.ts
@@ -43,6 +43,7 @@ export const CONSOLE_RESPONSE_ACTION_COMMANDS = [
   'kill-process',
   'suspend-process',
   'processes',
+  'get-file',
 ] as const;
 
 export type ConsoleResponseActionCommands = typeof CONSOLE_RESPONSE_ACTION_COMMANDS[number];
diff --git a/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/use_action_history_url_params.test.ts b/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/use_action_history_url_params.test.ts
@@ -5,8 +5,18 @@
  * 2.0.
  */
 import { actionsLogFiltersFromUrlParams } from './use_action_history_url_params';
+import type { ConsoleResponseActionCommands } from '../../../../../common/endpoint/service/response_actions/constants';
+import { CONSOLE_RESPONSE_ACTION_COMMANDS } from '../../../../../common/endpoint/service/response_actions/constants';
 
 describe('#actionsLogFiltersFromUrlParams', () => {
+  const getConsoleCommandsAsString = (): string => {
+    return [...CONSOLE_RESPONSE_ACTION_COMMANDS].sort().join(',');
+  };
+
+  const getConsoleCommandsAsArray = (): ConsoleResponseActionCommands[] => {
+    return [...CONSOLE_RESPONSE_ACTION_COMMANDS].sort();
+  };
+
   it('should not use invalid command values from URL params', () => {
     expect(actionsLogFiltersFromUrlParams({ commands: 'asa,was' })).toEqual({
       commands: undefined,
@@ -21,10 +31,10 @@ describe('#actionsLogFiltersFromUrlParams', () => {
   it('should use valid command values from URL params', () => {
     expect(
       actionsLogFiltersFromUrlParams({
-        commands: 'kill-process,isolate,processes,release,suspend-process',
+        commands: getConsoleCommandsAsString(),
       })
     ).toEqual({
-      commands: ['isolate', 'kill-process', 'processes', 'release', 'suspend-process'],
+      commands: getConsoleCommandsAsArray(),
       endDate: undefined,
       hosts: undefined,
       startDate: undefined,
@@ -62,15 +72,15 @@ describe('#actionsLogFiltersFromUrlParams', () => {
   it('should use valid command and status along with given host, user and date values from URL params', () => {
     expect(
       actionsLogFiltersFromUrlParams({
-        commands: 'release,kill-process,isolate,processes,suspend-process',
+        commands: getConsoleCommandsAsString(),
         statuses: 'successful,pending,failed',
         hosts: 'host-1,host-2',
         users: 'user-1,user-2',
         startDate: '2022-09-12T08:00:00.000Z',
         endDate: '2022-09-12T08:30:33.140Z',
       })
     ).toEqual({
-      commands: ['isolate', 'kill-process', 'processes', 'release', 'suspend-process'],
+      commands: getConsoleCommandsAsArray(),
       endDate: '2022-09-12T08:30:33.140Z',
       hosts: ['host-1', 'host-2'],
       startDate: '2022-09-12T08:00:00.000Z',
