Skip to content

Minor text updates to tty toggle tooltip and capture_mode advanced option#142665

Merged
mitodrummer merged 6 commits intoelastic:mainfrom
mitodrummer:tty_option_text_updates
Oct 11, 2022
Merged

Minor text updates to tty toggle tooltip and capture_mode advanced option#142665
mitodrummer merged 6 commits intoelastic:mainfrom
mitodrummer:tty_option_text_updates

Conversation

@mitodrummer
Copy link
Copy Markdown
Contributor

@mitodrummer mitodrummer commented Oct 4, 2022

Summary

Minor revisions to text.

Checklist

Delete any items that are not applicable to this PR.

@mitodrummer mitodrummer added bug Fixes for quality problems that affect the customer experience Team: AWP: Sensor AWP Sensor Team Team: AWP: Visualization AWP team that does most fullstack work in kibana backport:prev-minor v8.5.0 labels Oct 4, 2022
@mitodrummer mitodrummer requested a review from a team as a code owner October 4, 2022 19:51
@mitodrummer mitodrummer added the release_note:skip Skip the PR/issue when compiling release notes label Oct 4, 2022
@mitodrummer mitodrummer self-assigned this Oct 5, 2022
@mitodrummer mitodrummer requested a review from kevinlog October 5, 2022 19:01
@mitodrummer mitodrummer enabled auto-merge (squash) October 5, 2022 20:19
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Alerts detection rules table auto-refresh should disable auto refresh when any rule selected and enable it after rules unselected

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +158.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mitodrummer

@mitodrummer
Copy link
Copy Markdown
Contributor Author

@elastic/security-onboarding-and-lifecycle-mgt would be great to get a 👍 on this before BC4 is cut. Hopefully since it's just text corrections, it's not too late.

@mitodrummer mitodrummer merged commit 85667b8 into elastic:main Oct 11, 2022
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 11, 2022
…tion (elastic#142665)

* minor text updates to tty toggle tooltip and capture_mode advanced option

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* text tweaks

Co-authored-by: Karl Godard <karlgodard@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 85667b8)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 11, 2022
…tion (#142665) (#143115)

* minor text updates to tty toggle tooltip and capture_mode advanced option

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* text tweaks

Co-authored-by: Karl Godard <karlgodard@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 85667b8)

Co-authored-by: Karl Godard <karl.godard@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Sensor AWP Sensor Team Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.5.0 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants