[APM] Synthtrace: Add distributed trace helper#142593
Merged
sorenlouv merged 7 commits intoelastic:mainfrom Oct 12, 2022
Merged
[APM] Synthtrace: Add distributed trace helper#142593sorenlouv merged 7 commits intoelastic:mainfrom
sorenlouv merged 7 commits intoelastic:mainfrom
Conversation
fbad69e to
e1a013d
Compare
kpatticha
reviewed
Oct 5, 2022
kpatticha
reviewed
Oct 5, 2022
Contributor
|
Pinging @elastic/apm-ui (Team:APM) |
kpatticha
reviewed
Oct 10, 2022
packages/kbn-apm-synthtrace/src/scenarios/helpers/distributed_trace_client.ts
Outdated
Show resolved
Hide resolved
kpatticha
approved these changes
Oct 10, 2022
Contributor
kpatticha
left a comment
There was a problem hiding this comment.
Thanks for adding the helper. Overall LGTM, I left a small comment about file structure
8957b82 to
320c7a1
Compare
320c7a1 to
4379bd4
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 12, 2022
(cherry picked from commit 005a6ea)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a helper to synthtrace that makes it easier to write distributed tracing scenarios where multiple services call each other.
Example of a trace built with the new DistributedTrace scenario