Skip to content

[APM] Synthtrace: Add distributed trace helper#142593

Merged
sorenlouv merged 7 commits intoelastic:mainfrom
sorenlouv:add-distriuted-trace-helper
Oct 12, 2022
Merged

[APM] Synthtrace: Add distributed trace helper#142593
sorenlouv merged 7 commits intoelastic:mainfrom
sorenlouv:add-distriuted-trace-helper

Conversation

@sorenlouv
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv commented Oct 4, 2022

This adds a helper to synthtrace that makes it easier to write distributed tracing scenarios where multiple services call each other.

Example of a trace built with the new DistributedTrace scenario

image

image

@sorenlouv sorenlouv requested a review from a team October 4, 2022 12:36
@sorenlouv sorenlouv marked this pull request as draft October 4, 2022 12:37
@sorenlouv sorenlouv added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Oct 4, 2022
@sorenlouv sorenlouv force-pushed the add-distriuted-trace-helper branch from fbad69e to e1a013d Compare October 5, 2022 07:06
@sorenlouv sorenlouv marked this pull request as ready for review October 5, 2022 12:53
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Copy Markdown
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the helper. Overall LGTM, I left a small comment about file structure

@sorenlouv sorenlouv force-pushed the add-distriuted-trace-helper branch from 8957b82 to 320c7a1 Compare October 11, 2022 12:53
@sorenlouv sorenlouv force-pushed the add-distriuted-trace-helper branch from 320c7a1 to 4379bd4 Compare October 11, 2022 21:14
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
@kbn/apm-synthtrace 2 3 +1

Total ESLint disabled count

id before after diff
@kbn/apm-synthtrace 11 12 +1

History

  • 💔 Build #79368 failed 320c7a14e86ed6fdfd39bd8579b96fb55ffcbdec
  • 💛 Build #78357 was flaky c906bfa1906c310a970e94b22d69e66b4d55d770
  • 💔 Build #78345 failed cea844707e7ac82756a05b07c776eb92a99dc98d
  • 💔 Build #78232 failed 9d2a02a0fc2c31197fed2846e21652c772093b65
  • 💔 Build #78219 failed bc325303220f0f1a506d56b7944fe2865a1ac429

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 005a6ea into elastic:main Oct 12, 2022
@sorenlouv sorenlouv deleted the add-distriuted-trace-helper branch October 12, 2022 07:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 12, 2022
(cherry picked from commit 005a6ea)

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.5.0 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants