[Discover] Advanced integration of adhoc Data Views by dimaanj · Pull Request #139984 · elastic/kibana

dimaanj · 2022-09-02T15:39:00Z

Summary

Follow up of #138283

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…x data view picker

…ce-hoc-data-views # Conflicts: # src/plugins/unified_search/public/dataview_picker/change_dataview.tsx # test/functional/page_objects/unified_search_page.ts

…ce-hoc-data-views # Conflicts: # src/plugins/discover/public/__mocks__/services.ts # src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx

…nj/kibana into complete-adhoc-data-view-integration

…nj/kibana into complete-adhoc-data-view-integration # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/utils.tsx

…nj/kibana into complete-adhoc-data-view-integration

kibana-ci · 2022-09-08T09:09:57Z

💚 Build Succeeded

Buildkite Build
Commit: 5718127

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	527	530	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`discover`	78	79	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataViewEditor`	31.9KB	31.9KB	+6.0B
`discover`	463.1KB	467.8KB	+4.7KB
`lens`	1.2MB	1.2MB	-20.0B
total			+4.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	430.6KB	430.7KB	+147.0B
`discover`	26.1KB	26.2KB	+130.0B
`maps`	81.2KB	81.2KB	+2.0B
total			+279.0B

Unknown metric groups

API count

id	before	after	diff
`discover`	95	96	+1

ESLint disabled line counts

id	before	after	diff
`data`	46	47	+1
`discover`	37	38	+1
total			+2

References to deprecated APIs

id	before	after	diff
`lens`	4	3	-1

Total ESLint disabled count

id	before	after	diff
`data`	48	49	+1
`discover`	38	39	+1
total			+2

History

💚 Build #70079 succeeded 53150b9
💚 Build #70003 succeeded 50831d9
💚 Build #69705 succeeded 7b9b70a
💚 Build #69626 succeeded a52c36b
💔 Build #69596 failed 4481b90
💔 Build #69278 failed 9c47b85

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

dimaanj · 2022-09-28T15:31:57Z

Closing it, since #140885 created instead

dimaanj and others added 30 commits August 8, 2022 18:13

[Discover] add first steps for hoc data views

ed88667

[Discover] add confirm prompt when needed

5452bb5

[Discover] fix types

57f817d

[Discover] fix tests

bde621f

[Discover] fix remaining tests

4023723

Merge branch 'main' into introduce-hoc-data-views

e091cba

[Discover] fix some comments

f5a139a

Merge branch 'main' into introduce-hoc-data-views

64683a2

[Discover] refactor, fix some bugs

d48db7d

[Discover] add functional tests

1d41ecc

[Discover] improve tests

1e20a4a

Merge branch 'main' into introduce-hoc-data-views

39dd358

[Discover] fix test

340a4ce

[Discover] add saved data view toast

7557d38

[Discover] fix unit tests

74ab106

Merge branch 'main' into introduce-hoc-data-views

a537661

[Discover] fix remaining tests

b5b7dad

Merge branch 'main' into introduce-hoc-data-views

7b87a05

Merge branch 'main' into introduce-hoc-data-views

79f4223

Merge branch 'main' into introduce-hoc-data-views

8ba211f

[Discover] resolve comments

691e3a6

[Discover] generate new id on saving search copy, add functionals, fi…

4ca9088

…x data view picker

Merge branch 'main' of https://github.com/elastic/kibana into introdu…

6009d8d

…ce-hoc-data-views # Conflicts: # src/plugins/unified_search/public/dataview_picker/change_dataview.tsx # test/functional/page_objects/unified_search_page.ts

[Discover] fix bug with top nav actions

6737b53

[Discover] enable stats for adhocs

9cec88a

[Discover] fix lint

e3b7f9b

[Discover] remove duplications

b33a83c

Merge branch 'main' into introduce-hoc-data-views

739a0ca

[Discover] clean up changes

8f09895

[Discover] enable sql view, fix functional test

85f7590

dimaanj self-assigned this Sep 2, 2022

dimaanj mentioned this pull request Sep 2, 2022

[Discover] Implement ad-hoc data views #138283

Merged

4 tasks

dimaanj added 3 commits September 2, 2022 18:49

Merge branch 'main' of https://github.com/elastic/kibana into introdu…

575cca4

…ce-hoc-data-views # Conflicts: # src/plugins/discover/public/__mocks__/services.ts # src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx

[Discover] fix types

9bdf99a

Merge branch 'introduce-hoc-data-views' of https://github.com/Dmitriy…

9c47b85

…nj/kibana into complete-adhoc-data-view-integration

dimaanj added the WIP Work in progress label Sep 5, 2022

dimaanj and others added 21 commits September 5, 2022 18:05

[Discover] fix maps visualization

089dc75

Merge branch 'main' into introduce-hoc-data-views

3f744ea

[Discover] fix checks

492528d

[Discover] fix fields drag and drop

5682b2f

[Discover] fix checks

6223991

Merge branch 'main' into introduce-hoc-data-views

5308a8b

[Discover] remove logs

58cdda1

Merge branch 'introduce-hoc-data-views' of https://github.com/Dmitriy…

4481b90

…nj/kibana into complete-adhoc-data-view-integration # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/utils.tsx

[Discover] add locator test

a52c36b

[Lens] apply suggestions

4f3d4d5

Merge branch 'introduce-hoc-data-views' of https://github.com/Dmitriy…

7b9b70a

…nj/kibana into complete-adhoc-data-view-integration

[Discover] add ignoreFetchState flag

7c8878f

[Discover] improve nav link issue solution

293df63

[Discover] fix type checks

2bf98e1

Merge branch 'introduce-hoc-data-views' of https://github.com/Dmitriy…

50831d9

…nj/kibana into complete-adhoc-data-view-integration

[Lens] use data view spec without fields for lens discover transition

53150b9

[Discover] allow multiple adhoc data views

e3e3597

[Discover] use light spec for vis action payload

600aa7a

[Discover] fix check types

c8cb377

Merge branch 'main' into introduce-hoc-data-views

345f77a

Merge branch 'introduce-hoc-data-views' of https://github.com/Dmitriy…

5718127

…nj/kibana into complete-adhoc-data-view-integration

dimaanj closed this Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Advanced integration of adhoc Data Views#139984

[Discover] Advanced integration of adhoc Data Views#139984
dimaanj wants to merge 60 commits intoelastic:mainfrom
dimaanj:complete-adhoc-data-view-integration

dimaanj commented Sep 2, 2022 •

edited

Loading

Uh oh!

kibana-ci commented Sep 8, 2022

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

Uh oh!

dimaanj commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dimaanj commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

kibana-ci commented Sep 8, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

Uh oh!

dimaanj commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dimaanj commented Sep 2, 2022 •

edited

Loading