Skip to content

[Discover] Enable esQuery alert for adhoc data views#140885

Merged
dimaanj merged 59 commits intoelastic:mainfrom
dimaanj:enable-alerts-for-adhoc-data-views
Nov 9, 2022
Merged

[Discover] Enable esQuery alert for adhoc data views#140885
dimaanj merged 59 commits intoelastic:mainfrom
dimaanj:enable-alerts-for-adhoc-data-views

Conversation

@dimaanj
Copy link
Copy Markdown
Contributor

@dimaanj dimaanj commented Sep 16, 2022 •
edited
Loading

Summary

Closes #142514 #142389

This PR does the following:

  • Enables to create esQuery (in KQL or Lucene mode) using adhoc data views from discover and management pages
  • Adds explore matching indices button to data view picker in alert flyout
  • Adding adhoc data views from alert flyout should propage them to a main discover picker

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

@dimaanj dimaanj self-assigned this Sep 16, 2022
@dimaanj
Copy link
Copy Markdown
Contributor Author

dimaanj commented Sep 20, 2022

@elasticmachine merge upstream

@dimaanj dimaanj added release_note:enhancement WIP Work in progress Feature:Discover Discover Application Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Sep 20, 2022
@dimaanj
Copy link
Copy Markdown
Contributor Author

dimaanj commented Sep 23, 2022

@elasticmachine merge upstream

@dimaanj dimaanj mentioned this pull request Sep 28, 2022
Closed
9 tasks
@dimaanj
Copy link
Copy Markdown
Contributor Author

dimaanj commented Oct 30, 2022

@elasticmachine merge upstream

@dimaanj dimaanj removed the WIP Work in progress label Oct 30, 2022
@dimaanj dimaanj requested review from kertal and ppisljar October 30, 2022 14:01
davismcphee
davismcphee approved these changes Nov 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a chance to fix the types PR today so it should be good to merge: dimaanj#7. I also did a final round of local testing and code review and assuming we merge the types PR, this LGTM 👍

@kertal
Copy link
Copy Markdown
Member

kertal commented Nov 2, 2022

@elasticmachine merge upstream

lukasolson
lukasolson approved these changes Nov 3, 2022
View reviewed changes
@dimaanj dimaanj removed the request for review from ppisljar November 4, 2022 08:29
@dimaanj
Merge branch 'main' of https://github.com/elastic/kibana into enable-…
e911a7b 
…alerts-for-adhoc-data-views

# Conflicts:
#	src/plugins/discover/public/application/main/discover_main_route.test.tsx
#	src/plugins/discover/public/application/main/discover_main_route.tsx
#	src/plugins/discover/public/locator.ts
@ymao1
Copy link
Copy Markdown
Contributor

ymao1 commented Nov 4, 2022

fyi i renamed alert_types to rule_types in this PR: #144613

@dimaanj
Merge branch 'main' of https://github.com/elastic/kibana into enable-…
3fe9a05 
…alerts-for-adhoc-data-views

# Conflicts:
#	x-pack/plugins/stack_alerts/public/plugin.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/es_query_expression.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/expression.test.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/expression.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/search_source_expression.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/expression/search_source_expression_form.tsx
#	x-pack/plugins/stack_alerts/public/rule_types/es_query/types.ts
#	x-pack/plugins/stack_alerts/public/rule_types/index.ts
#	x-pack/plugins/stack_alerts/server/index.ts
@dimaanj
[Discover] add getToastContent
25dab32
kertal
kertal approved these changes Nov 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick final review. Discover code LGTM, tested by creating 2 ad-hoc dataview based alert rules with the cloud instance ... one in Discover, one in Stack management. Got the notifications in the slack channel. What a ride, congrats!

@dimaanj
Merge branch 'main' of https://github.com/elastic/kibana into enable-…
5e1034f 
…alerts-for-adhoc-data-views

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/sections/rule_form/rule_add.test.tsx
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Nov 9, 2022 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Upgrade Assistant Deprecation pages "before all" hook for "renders the Elasticsearch deprecations page"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackAlerts 65 66 +1
unifiedSearch 170 185 +15
total +16

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2553 2555 +2
triggersActionsUi 497 499 +2
unifiedSearch 104 106 +2
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 413.0KB 414.0KB +1.0KB
stackAlerts 74.0KB 74.6KB +654.0B
triggersActionsUi 658.7KB 659.0KB +239.0B
unifiedSearch 216.2KB 216.2KB +11.0B
total +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 401.3KB 401.3KB +6.0B
stackAlerts 14.0KB 14.0KB +10.0B
unifiedSearch 49.7KB 57.0KB +7.3KB
total +7.3KB
Unknown metric groups

API count

id before after diff
data 3263 3265 +2
triggersActionsUi 526 528 +2
unifiedSearch 131 134 +3
total +7

ESLint disabled in files

id before after diff
osquery 1 2 +1
stackAlerts 1 0 -1
total -0

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
stackAlerts 26 25 -1
total +19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

@dimaanj dimaanj merged commit a9162f7 into elastic:main Nov 9, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Nov 9, 2022
@ymao1 ymao1 mentioned this pull request Nov 10, 2022
Closed
@kertal kertal mentioned this pull request Nov 14, 2022
Closed
@kertal kertal mentioned this pull request Nov 22, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jughosta jughosta jughosta left review comments

@stratoula stratoula stratoula left review comments

@kertal kertal kertal approved these changes

@lukasolson lukasolson lukasolson approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

@darnautov darnautov darnautov approved these changes

@ymao1 ymao1 ymao1 approved these changes

@davismcphee davismcphee davismcphee approved these changes

+1 more reviewer

@ari-aviran ari-aviran ari-aviran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dimaanj dimaanj

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Discover Discover Application release_note:enhancement Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.6.0

Projects

No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover] Enable esQuery alert for adhoc data views