Fix cloud test failures for 8.4 by liza-mae · Pull Request #139155 · elastic/kibana

liza-mae · 2022-08-18T23:12:51Z

Fixes

[test-failed]: Chrome UI Functional Tests.test/functional/apps/dashboard_elements/controls/control_group_chaining·ts - dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining "before all" hook for "Shows all available options in first Options List control" #136885
[test-failed]: Chrome UI Functional Tests.test/functional/apps/dashboard_elements/controls/options_list·ts - dashboard elements dashboard elements Controls Dashboard options list integration Options List Control creation and editing experience editing other control settings keeps selections #137743
[test-failed]: Chrome UI Functional Tests.test/functional/apps/dashboard/group6/dashboard_query_bar·ts - dashboard app - group 1 dashboard query bar causes panels to reload when refresh is clicked #133431
[test-failed]: Chrome UI Functional Tests.test/functional/apps/dashboard/group1/url_field_formatter·ts - dashboard app - group 1 Changing field formatter to Url applied on discover #137742
[test-failed]: X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/usage/api_counters·ts - Reporting APIs Usage Usage Counters configuration settings of the tests_server #139141
[test-failed]: X-Pack Reporting API Integration Tests.x-pack/test/reporting_api_integration/reporting_and_security/validation·ts - Reporting APIs Job parameter validation pngV2 fails if width or height are non-numeric #139142
[test-failed]: Chrome UI Functional Tests.test/functional/apps/management/_data_view_relationships·ts - management data view relationships Render relationships tab and verify count #135578
[test-failed]: Chrome UI Functional Tests.test/functional/apps/dashboard_elements/controls/replace_controls·ts - dashboard elements dashboard elements Controls Replacing controls Replace options list "before each" hook for "with range slider" #136886

Reporting

I am skipping a test that is looking for configuration settings on the server because I am assuming on cloud those settings will not be visible so this test is not applicable. Someone from the reporting team will need to confirm if this is correct or a bug.
For another test I increased the timeout, as it takes a bit longer on cloud

Dashboard Tests

Added security roles to dashboard tests

Management Test

Added a wait for page to load to the management test

x-pack/test/reporting_api_integration/reporting_and_security/usage/api_counters.ts

Heenawter

Code only review - added security roles to recently added Dashboard tests. Thanks so much for fixing this - everything looks good! 👍

liza-mae · 2022-08-22T15:56:29Z

@elasticmachine merge upstream

kibana-ci · 2022-08-22T16:43:13Z

💚 Build Succeeded

Buildkite Build
Commit: 75aa245

Metrics [docs]

✅ unchanged

History

💚 Build #66184 succeeded 878495f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

tsullivan · 2022-08-22T21:29:50Z

x-pack/test/reporting_api_integration/reporting_and_security/validation.ts

        );

-        await retry.tryForTime(48000, async () => {
+        await retry.tryForTime(60000, async () => {


Is this to resolve #139142 ?

Yes I noticed this test takes a bit longer on cloud, so I increased the retry.

kibanamachine · 2022-08-22T23:55:49Z

💔 All backports failed

Status	Branch	Result
❌	8.4	Backport failed because of merge conflicts You might need to backport the following PRs to 8.4: - [Archive Migrations] reporting-ecommerce_kibana_spaces - using an api in conjuction with migration (#136288)

Manual backport

To create the backport manually run:

node scripts/backport --pr 139155

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

liza-mae · 2022-08-23T01:25:17Z

💚 All backports created successfully

Status	Branch	Result
✅	8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6e87b01)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Fix cloud test failures for 8.4

878495f

liza-mae added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.5.0 labels Aug 18, 2022

liza-mae self-assigned this Aug 18, 2022

liza-mae requested review from a team as code owners August 18, 2022 23:12

vadimkibana approved these changes Aug 20, 2022

View reviewed changes

x-pack/test/reporting_api_integration/reporting_and_security/usage/api_counters.ts Show resolved Hide resolved

Heenawter approved these changes Aug 22, 2022

View reviewed changes

Merge branch 'main' into liza/fix-cloud-tests

75aa245

tsullivan reviewed Aug 22, 2022

View reviewed changes

tsullivan approved these changes Aug 22, 2022

View reviewed changes

liza-mae merged commit 6e87b01 into elastic:main Aug 22, 2022

liza-mae deleted the liza/fix-cloud-tests branch August 22, 2022 23:52

liza-mae mentioned this pull request Aug 23, 2022

[8.4] Fix cloud test failures for 8.4 (#139155) #139259

Merged

liza-mae added a commit that referenced this pull request Aug 23, 2022

Fix cloud test failures for 8.4 (#139155) (#139259)

28c5a8c

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6e87b01)

Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022

Fix cloud test failures for 8.4 (elastic#139155)

1922fe4

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix cloud test failures for 8.4#139155

Fix cloud test failures for 8.4#139155
liza-mae merged 2 commits intoelastic:mainfrom
liza-mae:liza/fix-cloud-tests

liza-mae commented Aug 18, 2022 •

edited

Loading

Uh oh!

Uh oh!

Heenawter left a comment

Uh oh!

liza-mae commented Aug 22, 2022

Uh oh!

kibana-ci commented Aug 22, 2022

Uh oh!

tsullivan Aug 22, 2022

Uh oh!

liza-mae Aug 22, 2022

Uh oh!

kibanamachine commented Aug 22, 2022

Uh oh!

liza-mae commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

liza-mae commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

liza-mae commented Aug 22, 2022

Uh oh!

kibana-ci commented Aug 22, 2022

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

tsullivan Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

liza-mae Aug 22, 2022

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 22, 2022

💔 All backports failed

Manual backport

Questions ?

Uh oh!

liza-mae commented Aug 23, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liza-mae commented Aug 18, 2022 •

edited

Loading