Skip to content

Small clean up with visualize test + extra debug log#13755

Merged
stacey-gammon merged 1 commit intoelastic:masterfrom
stacey-gammon:test/flaky-add-new-visualization-link
Aug 30, 2017
Merged

Small clean up with visualize test + extra debug log#13755
stacey-gammon merged 1 commit intoelastic:masterfrom
stacey-gammon:test/flaky-add-new-visualization-link

Conversation

@stacey-gammon
Copy link
Copy Markdown

@stacey-gammon stacey-gammon commented Aug 29, 2017

Investigate and fix #13754

@stacey-gammon stacey-gammon added Feature:Dashboard Dashboard related features :Sharing test labels Aug 29, 2017
@stacey-gammon stacey-gammon mentioned this pull request Aug 29, 2017
Closed
@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 29, 2017

First run passed the test in question, though failed at the end due to an s3 upload error. So for our intents, it counts as a pass:

 debg  isGlobalLoadingIndicatorVisible
13:49:31 01:49:31.829          │ debg  TestSubjects.exists(globalLoadingIndicator)
13:49:31 01:49:31.829          │ debg  existsByDisplayedByCssSelector [data-test-subj~="globalLoadingIndicator"]
13:49:31 01:49:31.901          │ debg  isGlobalLoadingIndicatorHidden
13:49:31 01:49:31.902          │ debg  findByCssSelector [data-test-subj="globalLoadingIndicator"].ng-hide
13:49:32 01:49:32.087          │ debg  in displayedByCssSelector: kbn-truncated.toast-message.ng-isolate-scope
13:49:32 01:49:32.160          │ debg  getToastMessage: Visualization Editor: Saved Visualization "visualization from add new link"
13:49:32 01:49:32.160          │ debg  clickToastOK
13:49:32 01:49:32.884          │ debg  in findAllByCssSelector: li.gs-w
13:49:33 01:49:33.405          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.410          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.414          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.420          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.425          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.430          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.435          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:33 01:49:33.439          │ debg  Find.childDisplayedByCssSelector: [data-test-subj~="dashboardPanelTitle"]
13:49:34 01:49:34.040          │ info  visualization titles = Visualization PieChart,Visualization☺ VerticalBarChart,Visualization漢字 AreaChart,Visualization☺漢字 DataTable,Visualization漢字 LineChart,Visualization TileMap,Visualization MetricChart,visualization from add new link
13:49:34 01:49:34.041          │ debg  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/test/functional/screenshots/session/Dashboard-visualization-sizes.png"
13:49:34 01:49:34.042          └- ✓ pass

Not that I did anything to actually fix it, but am curious to see how the output looks during a failure and how flaky this test is.

Jenkins, test this.

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 29, 2017

Second time passed.

Jenkins, test this.

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 29, 2017

Passed a third time.

cc @timroes -- any idea how often I should be seeing this error? I doubt my slight changes fixed it. I could perhaps check this in since it's just a small clean up, and then the next time we'll run into it I'll at least have a little extra debug out.

Jenkins test this.

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 29, 2017

another failure for s3, but a pass for the add new visualization link test.

jenkins, test this

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 29, 2017

Unit test failures this time:

18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 869 of 872 SUCCESS (0 secs / 3.595 secs)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0)  "before each" hook FAILED
18:44:36 	Error: Uncaught TypeError: Cannot read property 'key' of undefined (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:99966)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 870 of 872 (1 FAILED) (0 secs / 3.595 secs)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 871 of 872 (1 FAILED) (0 secs / 3.606 secs)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0)  "after each" hook FAILED
18:44:36 	TypeError: Cannot read property '$injector' of null
18:44:36 	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:101948:32)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 872 of 872 (2 FAILED) (0 secs / 3.615 secs)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0)  "after each" hook FAILED
18:44:36 	TypeError: Cannot read property '$injector' of null
18:44:36 	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:101948:32)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 873 of 872 (3 FAILED) (0 secs / 3.615 secs)
18:44:36 Chrome 59.0.3071 (Linux 0.0.0): Executed 873 of 872 (3 FAILED) (28.513 secs / 3.615 secs)
18:44:36 Warning: Task "karma:ciShard-1" failed.� Use --force to continue.
18:44:36 
18:44:36 Aborted due to warnings.

Not much information as to where they are coming from. Though not the test I am investigating.

This last run is a no-op. Will sync with master to see if I need some changes.

@stacey-gammon stacey-gammon force-pushed the test/flaky-add-new-visualization-link branch from 906e73a to 95db986 Compare August 29, 2017 20:49
@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 30, 2017

Passed 5 times. Lets get this checked in and if any more errors occur I'll take another look. There were two toast message statements in a row and I wanted to see which one was failing. Hopefully the added debug line will help when it hits again.

To be clear, I don't believe I fixed the bug, but perhaps changing the code slightly altered the timing and made it hard to reproduce.

@stacey-gammon stacey-gammon requested a review from timroes August 30, 2017 13:01
@stacey-gammon stacey-gammon changed the title Investigate flaky add new visualization link test Small clean up with visualize test + extra debug log Aug 30, 2017
@stacey-gammon stacey-gammon merged commit fa2edca into elastic:master Aug 30, 2017
stacey-gammon pushed a commit to stacey-gammon/kibana that referenced this pull request Aug 30, 2017
Investigate flaky add new visualization link test (elastic#13755)
c398ce9
stacey-gammon pushed a commit to stacey-gammon/kibana that referenced this pull request Aug 30, 2017
Investigate flaky add new visualization link test (elastic#13755)
d652e4d
This was referenced Aug 30, 2017
Merged
Merged
stacey-gammon pushed a commit that referenced this pull request Aug 31, 2017
Investigate flaky add new visualization link test (#13755) (#13776)
41b6f06
stacey-gammon pushed a commit that referenced this pull request Aug 31, 2017
Investigate flaky add new visualization link test (#13755) (#13777)
503d920
@stacey-gammon stacey-gammon deleted the test/flaky-add-new-visualization-link branch October 24, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timroes timroes timroes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Dashboard Dashboard related features test v6.0.0-rc1 v6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate possible flaky test

3 participants

@stacey-gammon @timroes @jimgoodwin