Skip to content

Fix relative z-index of spy panel and filter editor#13717

Merged
Bargs merged 2 commits intoelastic:masterfrom
Bargs:fixSpyDepth
Aug 28, 2017
Merged

Fix relative z-index of spy panel and filter editor#13717
Bargs merged 2 commits intoelastic:masterfrom
Bargs:fixSpyDepth

Conversation

@Bargs
Copy link
Copy Markdown
Contributor

@Bargs Bargs commented Aug 25, 2017

I noticed the spy panel button was appearing above the filter editor in discover. The entire spy panel also appeared above it if it was open. This PR updates the discover-wrapper's z-index so that all content in the main content area appears below the filter bar content.

Before
screen shot 2017-08-25 at 5 15 56 pm

After
screen shot 2017-08-25 at 5 30 26 pm

@lukasolson
Copy link
Copy Markdown
Contributor

Hmm, I'm not able to reproduce the original error. I'm on master and I'm not seeing the spy button over the filter editor panel...

@Bargs
Copy link
Copy Markdown
Contributor Author

Bargs commented Aug 28, 2017

@lukasolson what browser are you testing in? I see this issue in Chrome and Firefox, but not Safari. Just pulled down the latest master and confirmed it's still happening.

Looking into test failure atm, could be related but not sure yet, having some issues with running tests locally this morning.

@lukasolson
Copy link
Copy Markdown
Contributor

lukasolson commented Aug 28, 2017

what browser are you testing in?

I tried Chrome, Safari, and Firefox, and didn't see it in any of them... 🤷‍♂️ What version of Chrome are you using?

I'll make sure I'm up to date in Chrome and give it another try.

@Bargs
Copy link
Copy Markdown
Contributor Author

Bargs commented Aug 28, 2017

Just updated all the things and I'm still seeing it.

Chrome: 60.0.3112.113
Chrome Canary: 62.0.3198.0
Firefox: 55.0.3

@lukasolson
Copy link
Copy Markdown
Contributor

Tried with x-pack installed, and was able to reproduce.

Copy link
Copy Markdown
Contributor

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🖌 😲

@Bargs Bargs merged commit 53d81c8 into elastic:master Aug 28, 2017
Bargs added a commit to Bargs/kibana that referenced this pull request Aug 28, 2017
* Fixes relative z-index of spy panel and filter editor

* Position sidebar above main content so collapser button remains clickable
Bargs added a commit to Bargs/kibana that referenced this pull request Aug 28, 2017
* Fixes relative z-index of spy panel and filter editor

* Position sidebar above main content so collapser button remains clickable
Bargs added a commit that referenced this pull request Aug 29, 2017
* Fixes relative z-index of spy panel and filter editor

* Position sidebar above main content so collapser button remains clickable
Bargs added a commit that referenced this pull request Aug 29, 2017
* Fixes relative z-index of spy panel and filter editor

* Position sidebar above main content so collapser button remains clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants