Map filter not set appropriately when spy panel is open#13678
Map filter not set appropriately when spy panel is open#13678nreese merged 2 commits intoelastic:masterfrom
Conversation
thomasneirynck
left a comment
There was a problem hiding this comment.
this works good.
@ppisljar and I discussed the other resize issue (collapsing doesn't trigger resize). The issue seems to be we're listening on the node containing the entire -tree, not just the container-node of the actual visualization. Resolving this may also alleviate the need to traverse up the element list.
This approach here is a pretty good heuristic though to get a meaningful width/height when the container has 0/0 dimensions. It will get a reasonable value, rather than using some fixed dimension.
Does this issue also prevent the circles from showing up? Or are you referring to only the whitespace (e.g. this issue - #13137)?
|
|
@stacey-gammon It is effecting both. Leaflet is created in an element with 0 height so it does not display the markers. Simply calling |
stacey-gammon
left a comment
There was a problem hiding this comment.
Can you file an issue for the new problems revealed just so we can keep track? Unless there already is one.
otherwise, lgtm.
|
@stacey-gammon new issue created - #13705 |
* get dimensions from parent elements when map has not height or width * clean up test variable names
* get dimensions from parent elements when map has not height or width * clean up test variable names
Fixes #13625
When a map visualization is added to a dashboard with the spy panel open, the leaflet map element has not height because the spy panel fills the entire panel. This causes problems because
getUntrimmedBoundsreturnedundefined. Instead of returningundefined,getUntrimmedBoundscan calculate the map dimensions based on the parent element dimensions.Fixing this issue revealed a new issue. Kibana_map does not call resize when the spy panel is opened/closed. This new issue should be resolved in a separate PR since its solution could effect other visualizations.