Skip to content

Removes webpack-directory-name-as-main dependency#13584

Merged
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:no-directory-as-main
Aug 23, 2017
Merged

Removes webpack-directory-name-as-main dependency#13584
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:no-directory-as-main

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

This plugin is one aspect preventing us from upgrading Webpack. This plugin also adds confusion as Node's pattern is to use an index.

@tylersmalley tylersmalley requested review from jbudz and spalger August 18, 2017 17:13
@tylersmalley tylersmalley force-pushed the no-directory-as-main branch 2 times, most recently from a53a6dd to e133363 Compare August 18, 2017 18:35
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Copy Markdown
Member Author

Jenkins, test it

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked updates, LGTM

@tylersmalley tylersmalley merged commit 4bbd127 into elastic:master Aug 23, 2017
@tylersmalley
Copy link
Copy Markdown
Member Author

@spalger, do you think I should backport this to 6.x? If we want to eventually bump Webpack there we should.

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Aug 25, 2017

@tylersmalley yeah

tylersmalley added a commit that referenced this pull request Aug 25, 2017
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Copy Markdown
Member Author

6.x/6.1: 854f795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants