[5.6] fork marked and remove npm marked dependency#13444
Conversation
kobelb
left a comment
There was a problem hiding this comment.
There are quite a few files that are candidates to being deleted, as they're something that we won't be using anymore with the way that marked is being imported/built.
Also, one of the tests for marked is failing right now, and I'd be interested to see if it could be integrated into our current test run as we're owning it now.
src/forked/marked/Gulpfile.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| var gulp = require('gulp'); | |||
There was a problem hiding this comment.
This Gulpfile will never be ran, as we're referencing the lib/marked from everything else, and using our own build process.
src/forked/marked/.travis.yml
Outdated
| @@ -0,0 +1,5 @@ | |||
| language: node_js | |||
There was a problem hiding this comment.
This file should probably be removed, we won't be using it.
src/forked/marked/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| node_modules/ | |||
There was a problem hiding this comment.
This is redundant, as the .gitignore in the project root already has this.
src/forked/marked/.npmignore
Outdated
| @@ -0,0 +1,2 @@ | |||
| .git* | |||
There was a problem hiding this comment.
This is unused as we won't be publishing a npm module for this.
src/forked/marked/Makefile
Outdated
| @@ -0,0 +1,12 @@ | |||
| all: | |||
There was a problem hiding this comment.
This should probably be deleted as well as we won't be building using make but our own build process.
src/forked/marked/bin/marked
Outdated
| @@ -0,0 +1,187 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
I don't see the benefit to leaving this here either.
src/forked/marked/bower.json
Outdated
| @@ -0,0 +1,24 @@ | |||
| { | |||
There was a problem hiding this comment.
The bower.json/component.json and package.json should probably be deleted as well, as this won't be used as a separate module. The devDependencies appear to be only used by the Gulpfile.js which I think should be deleted as well.
| @@ -1,4 +1,4 @@ | |||
| import marked from 'marked'; | |||
| import marked from '../../../forked/marked/lib/marked'; | |||
There was a problem hiding this comment.
We should be able to shorten this, and the other imports, to ../../../forked/marked
… shorten marked import path
|
nice! |
* fork marked and swap for npm marked dependency * remove unneeded files in marked fork, fix broken test in marked fork, shorten marked import path
fixes #13426
This PR forks the
markeddependency and moves the forked version undersrc/forked/marked.