Prevents default index pattern name when ID is provided#13353
Merged
tylersmalley merged 2 commits intoelastic:masterfrom Aug 16, 2017
Merged
Prevents default index pattern name when ID is provided#13353tylersmalley merged 2 commits intoelastic:masterfrom
tylersmalley merged 2 commits intoelastic:masterfrom
Conversation
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
7b77b0b to
9d87625
Compare
tylersmalley
commented
Aug 8, 2017
| // Configure the new index pattern we're going to create. | ||
| this.formValues = { | ||
| id: $routeParams.id ? decodeURIComponent($routeParams.id) : undefined, | ||
| id: undefined, |
Member
Author
There was a problem hiding this comment.
I suppose I could remove this
Contributor
|
Is this expected? |
Contributor
|
Nevermind, wrong page. Do you have reproduction steps? |
Member
Author
|
Yes, reproduction steps would be good. By visiting the create index pattern page with an id provided as a query parameter. Example: http://localhost:5601/app/kibana#/management/kibana/index?_g=()&id=ABC123 You should see the id advanced settings expanded with ABC123 filled out for the ID, and the index pattern should be blank. |
jbudz
approved these changes
Aug 8, 2017
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
BigFunger
suggested changes
Aug 16, 2017
| // Configure the new index pattern we're going to create. | ||
| this.formValues = { | ||
| id: $routeParams.id ? decodeURIComponent($routeParams.id) : undefined, | ||
| name: config.get('indexPattern:placeholder'), |
Contributor
There was a problem hiding this comment.
Why not follow the same pattern that was there?
name: $routeParams.id ? '' : config.get('indexPattern:placeholder')
Member
Author
There was a problem hiding this comment.
I felt like it was more straightforward to have a block which describes a scenario where the defaults were changed than to use inline if's. I am fine changing it if you think it reads better as inline if's.
chrisronline
approved these changes
Aug 16, 2017
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
I agree with Jim's suggestion, but otherwise, LGTM
tylersmalley
added a commit
that referenced
this pull request
Aug 16, 2017
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Aug 16, 2017
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Member
Author
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Aug 16, 2017
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 22, 2017
chrisronline
added a commit
that referenced
this pull request
Aug 24, 2017
* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, #13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy
chrisronline
added a commit
that referenced
this pull request
Aug 24, 2017
* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, #13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy
pugnascotia
pushed a commit
to elastic/eui
that referenced
this pull request
Oct 18, 2017
* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, elastic/kibana#13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13072