in percentage mode tooltip should also show percentages#13217
Merged
ppisljar merged 1 commit intoelastic:masterfrom Aug 1, 2017
Merged
in percentage mode tooltip should also show percentages#13217ppisljar merged 1 commit intoelastic:masterfrom
ppisljar merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
jenkins, test this |
Contributor
|
jenkins, test this. |
Contributor
|
jenkins, test this |
thomasneirynck
approved these changes
Jul 31, 2017
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
Okay, this makes sense. We won't do the labeling of the Y-axis for now (to show Percentage of ....).
Like how you grab the axis-config directly.
Contributor
|
Feel free to merge and backport to 6.x/6.0/5.x/5.5. Thx! |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by #13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 1, 2017
This fixes a regression introduced by elastic#13217.
This was referenced Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
thomasneirynck
added a commit
that referenced
this pull request
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note: Tooltips now correctly display the percentage-value in area charts where the Y-Axis is formatted in percentage mode.
Closes #12391
variation of #13212
#13212 tries to change the default label of aggregation when in percentage mode, which is actually not mentioned in #12391
this PR just fixes the bug with percentage mode (which was introduced by vislib refactor almost a year ago), so the old behavior is restored: when in percentage mode the tooltip should show both, the metric value and the percentage.