Skip to content

[Security Solution] fix flaky api integ tests#131939

Merged
joeypoon merged 1 commit intoelastic:mainfrom
joeypoon:fix/integ-tests
May 11, 2022
Merged

[Security Solution] fix flaky api integ tests#131939
joeypoon merged 1 commit intoelastic:mainfrom
joeypoon:fix/integ-tests

Conversation

@joeypoon
Copy link
Copy Markdown
Member

@joeypoon joeypoon commented May 10, 2022

Summary

Fix flaky api integration tests.

Flaky test run 1: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/591 100/100 ✅
Flaky test run 2: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/596 100/100 ✅
Flaky test run 3: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/598 100/100 ✅
Issue: #122220

For maintainers

@joeypoon joeypoon added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels May 10, 2022
@joeypoon joeypoon marked this pull request as ready for review May 10, 2022 21:26
@joeypoon joeypoon requested a review from a team as a code owner May 10, 2022 21:26
@joeypoon joeypoon requested review from parkiino and pzl May 10, 2022 21:26
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • 💔 Build #43739 failed 76258dd262b744d6c62685872abd6a75600c4ebe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@parkiino parkiino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same thing that @paul-tavares was talking about during office hours right?

@joeypoon joeypoon merged commit ca0f874 into elastic:main May 11, 2022
@joeypoon joeypoon deleted the fix/integ-tests branch May 11, 2022 16:10
@joeypoon
Copy link
Copy Markdown
Member Author

this is the same thing that @paul-tavares was talking about during office hours right?

sort of. in this case, we already had refresh: true which was forcing an immediate refresh vs this change makes it refresh: 'wait_for' which instead of forcing an immediate refresh, will wait for the next scheduled refresh.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 11, 2022
(cherry picked from commit ca0f874)

Co-authored-by: Joey F. Poon <joey.poon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants