Skip to content

Use version 0.9.0 of eslint-config-kibana#13177

Merged
weltenwort merged 1 commit intoelastic:masterfrom
weltenwort:enhancement/update-to-eslint-config-kibana-0-9-0
Jul 28, 2017
Merged

Use version 0.9.0 of eslint-config-kibana#13177
weltenwort merged 1 commit intoelastic:masterfrom
weltenwort:enhancement/update-to-eslint-config-kibana-0-9-0

Conversation

@weltenwort
Copy link
Copy Markdown
Member

@weltenwort weltenwort commented Jul 28, 2017

This updates the installed version of @elastic/eslint-config-kibana to 0.9.0. In doing so, several duplicate unit tests were discovered by the linter, which this removes. Tests that cause other warnings now have better names or are exempted via eslint-disable-next-line.

replaces #12975

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jul 28, 2017

👍 LGTM

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@weltenwort weltenwort removed the request for review from kimjoar July 28, 2017 16:02
@weltenwort weltenwort merged commit 2430fed into elastic:master Jul 28, 2017
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jul 28, 2017
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jul 28, 2017
weltenwort added a commit that referenced this pull request Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants