Skip to content

Expose refresh option to SavedObjectsImporter#131339

Merged
joshdover merged 1 commit intoelastic:mainfrom
joshdover:so-import/add-refresh-option
May 3, 2022
Merged

Expose refresh option to SavedObjectsImporter#131339
joshdover merged 1 commit intoelastic:mainfrom
joshdover:so-import/add-refresh-option

Conversation

@joshdover
Copy link
Copy Markdown
Contributor

@joshdover joshdover commented May 2, 2022

Summary

Adds the ability to set the refresh setting on the _bulk API call to Elasticsearch when importing saved objects via the SavedObjectImporter class. This will help us improve the performance of Integration package installation time significantly for packages with large numbers of SOs.

For example, the AWS package contains ~200 SOs and the bulk API call takes nearly 4 seconds:
image

Using refresh: false allowed me to shave off about 2.5 seconds:

image

@joshdover joshdover added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 2, 2022
@joshdover joshdover requested a review from a team as a code owner May 2, 2022 15:49
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
core 2524 2525 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshdover joshdover merged commit 1c47b23 into elastic:main May 3, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 3, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants