[Infra] Add getMetricIndices to start contract#131326
Merged
miltonhultgren merged 6 commits intoelastic:mainfrom May 3, 2022
Merged
[Infra] Add getMetricIndices to start contract#131326miltonhultgren merged 6 commits intoelastic:mainfrom
miltonhultgren merged 6 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
miltonhultgren
commented
May 2, 2022
x-pack/plugins/infra/server/lib/metrics/make_get_metric_indices.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
weltenwort
approved these changes
May 3, 2022
Member
weltenwort
left a comment
There was a problem hiding this comment.
LGTM, just left a few comments below
x-pack/plugins/infra/server/lib/metrics/make_get_metric_indices.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/metrics/make_get_metric_indices.ts
Outdated
Show resolved
Hide resolved
weltenwort
approved these changes
May 3, 2022
Member
weltenwort
left a comment
There was a problem hiding this comment.
LGTM if CI agrees - thanks for polishing!
x-pack/plugins/infra/server/lib/metrics/make_get_metric_indices.test.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* [Infra] Add getMetricIndices to start contract (elastic#131246) * Remove temporary return variable, change variable name * Address review comments * Use Jest Promise mock shorthand Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131246
To allow the APM side to make queries directly against our data they needed a way to know which indices to target, since this is configurable with our source configurations.
This PR adds a (very) simple function to the Infra start contract that once invoked with a given source configuration ID, will resolve that configuration and reply with the indices.