[Cloud Posture] add resource findings page#131325
Conversation
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
JordanSh
left a comment
There was a problem hiding this comment.
see comment about the id translation, if it's intended please ask for a re-review
|
|
||
| const BackToResourcesButton = () => { | ||
| return ( | ||
| <Link to={generatePath(findingsNavigation.findings_by_resource.path)}> |
There was a problem hiding this comment.
can we make this remember the page number you were in?
There was a problem hiding this comment.
currently it is out of scope of this task
There was a problem hiding this comment.
not sure i follow, but generally - there are no page numbers in group-by-resource as we fetch based on after_key, not an index
There was a problem hiding this comment.
I thought @JordanSh meant to save the state (in the url or other way)
but I see I might be wrong
| <BackToResourcesButton /> | ||
| <PageTitleText | ||
| title={ | ||
| <div style={{ padding: euiTheme.size.s }}> |
There was a problem hiding this comment.
i think you used size.l on other pages
| <FormattedMessage | ||
| id="xpack.csp.findings.resourceFindingsTitle" | ||
| defaultMessage="{resourceId} - Findings" | ||
| values={{ resourceId: params.resourceId }} |
There was a problem hiding this comment.
this doesn't make much sense to me, do we actually need to translate ids? their purpose is usually to be consistent. unless there's a reason for this i would remove it
There was a problem hiding this comment.
id is not translated, however in different languages you would like to position the id differently. therefore you see the placeholder of the resource id in the text
Summary
this PR adds a new URL route to
/findings/resource/:resourceIdand its matching placeholder component.we then use the
resourceIdparam to:Demo
Screen.Recording.2022-05-02.at.16.31.19.mov
Checklist
Delete any items that are not applicable to this PR.