ensure timezone attribute in tests is adhered to#13121
Merged
stacey-gammon merged 2 commits intoelastic:masterfrom Jul 26, 2017
Merged
ensure timezone attribute in tests is adhered to#13121stacey-gammon merged 2 commits intoelastic:masterfrom
stacey-gammon merged 2 commits intoelastic:masterfrom
Conversation
added 2 commits
July 26, 2017 11:12
Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with.
tylersmalley
approved these changes
Jul 26, 2017
Member
tylersmalley
left a comment
There was a problem hiding this comment.
LGTM - thanks for fixing this!
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 26, 2017
* ensure timezone attribute is adhered to Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with. * extra line to ensure server is stabilized to prevent transitory failures
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jul 26, 2017
* ensure timezone attribute is adhered to Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with. * extra line to ensure server is stabilized to prevent transitory failures
This was referenced Jul 26, 2017
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 26, 2017
* ensure timezone attribute is adhered to Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with. * extra line to ensure server is stabilized to prevent transitory failures
stacey-gammon
pushed a commit
that referenced
this pull request
Jul 26, 2017
* ensure timezone attribute is adhered to Two issues - one the archiver was loading the visualize mapping after the config setting so it was bring overwritten, and two, uiSettings.replace wasn’t working correctly to begin with. * extra line to ensure server is stabilized to prevent transitory failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues:
cc @tylersmalley @spalger