Skip to content

Updates esArchiver mappings to use single type#13107

Merged
spalger merged 1 commit intoelastic:masterfrom
tylersmalley:esarchiver-mapping
Jul 25, 2017
Merged

Updates esArchiver mappings to use single type#13107
spalger merged 1 commit intoelastic:masterfrom
tylersmalley:esarchiver-mapping

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Jul 25, 2017

No description provided.

@tylersmalley
Updates esArchiver mappings to use single type
d259811 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
spalger
spalger approved these changes Jul 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 460157d into elastic:master Jul 25, 2017
spalger pushed a commit that referenced this pull request Jul 25, 2017
@tylersmalley @spalger
Updates esArchiver mappings to use single type (#13107)
cc54853 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>(cherry picked from commit 460157d)
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Jul 25, 2017 •
edited
Loading

5.6: cc54853 reverted in 4b53e26

spalger added a commit that referenced this pull request Jul 25, 2017
@spalger
Revert "Updates esArchiver mappings to use single type (#13107)"
4b53e26 
This reverts commit cc54853.
@spalger spalger removed the v5.6.0 label Jul 25, 2017
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Jul 26, 2017

@tylersmalley @spalger This needs to go into 6.x and 6.0 as well, right?

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Jul 26, 2017

Also, this does appear to have a test failure in the esarchivers tests, but the test job is still turning out green:

✖ fail: "tests "before all" hook"
     │          │        [mapper_parsing_exception] No type specified for field [_default_]

Search for fail: in the intake console for all the details. We really need to figure out what the hell is going on with this esarchiver test stuff... I have no idea how this stuff is failing while still passing intake.

@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Jul 26, 2017

I will have a PR up shortly to resolve the test.

@spalger, it appears the esArchiver exception is being absorbed by the log.

tylersmalley added a commit that referenced this pull request Jul 26, 2017
@tylersmalley
Updates esArchiver mappings to use single type (#13107)
b0c4a6a 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit that referenced this pull request Jul 26, 2017
@tylersmalley
Updates esArchiver mappings to use single type (#13107)
4d8120d 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Jul 26, 2017

6.0: b0c4a6a
6.1/6.x: 4d8120d

@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Jul 26, 2017

Follow-up PR: #13122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylersmalley @spalger @epixa @jimgoodwin