[eslint-config-kibana] Add jest plugin and settings#13090
Merged
weltenwort merged 2 commits intoelastic:masterfrom Jul 28, 2017
Merged
[eslint-config-kibana] Add jest plugin and settings#13090weltenwort merged 2 commits intoelastic:masterfrom
weltenwort merged 2 commits intoelastic:masterfrom
Conversation
kimjoar
reviewed
Jul 25, 2017
Contributor
There was a problem hiding this comment.
This will always require the jest eslint plugin be installed, but I think that's okey. I don't see any harm in people not using Jest having to install this, as this works great for Kibana and xpack.
Member
Author
There was a problem hiding this comment.
Aren't peer dependencies always considered optional?
Contributor
There was a problem hiding this comment.
Ah, yeah, you'll just receive the warning
kimjoar
approved these changes
Jul 25, 2017
Member
Author
|
@spalger does this look good to you? |
88b34e0 to
02c79bc
Compare
cjcenizal
approved these changes
Jul 26, 2017
42d3724 to
c3ed527
Compare
This extracts the ui-specific eslint settings from elastic/kibana so they can be applied to other repositories as well.
c3ed527 to
e78698d
Compare
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 3, 2017
cjcenizal
added a commit
that referenced
this pull request
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the jest-specific eslint settings from Kibana's
.eslintrcinto theeslint-config-kibanapackage so they can be applied to projects living in other repositories as well.replaces elastic/eslint-config-kibana#9