date_histogram: some bars are too big#13068
Merged
nreese merged 2 commits intoelastic:masterfrom Jul 27, 2017
Merged
Conversation
ppisljar
approved these changes
Jul 25, 2017
Contributor
There was a problem hiding this comment.
maybe an a unit test to check for this ?
Contributor
Author
|
@ppisljar Added some unit tests if you want to review those. Turns out the defect only effected |
thomasneirynck
approved these changes
Jul 27, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 27, 2017
* handle data sets with holes * add unit tests
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 27, 2017
* handle data sets with holes * add unit tests
nreese
added a commit
that referenced
this pull request
Jul 27, 2017
nreese
added a commit
that referenced
this pull request
Jul 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes regression - #12995
Data sets with holes cause a problem because the calculated bar width spans the entire gap.
Backported to 6.x and 6.0