Skip to content

Remove premature abstraction#13042

Merged
chrisronline merged 1 commit intoelastic:masterfrom
chrisronline:remove/get_indices
Jul 25, 2017
Merged

Remove premature abstraction#13042
chrisronline merged 1 commit intoelastic:masterfrom
chrisronline:remove/get_indices

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

This PR removes an unused and unnecessary abstraction around fetching indices and template patterns.

Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ ⭐️ ⭐️ ⭐️ ⭐️

Copy link
Copy Markdown
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisronline chrisronline merged commit 95d3a37 into elastic:master Jul 25, 2017
chrisronline added a commit that referenced this pull request Jul 25, 2017
chrisronline added a commit that referenced this pull request Jul 25, 2017
@chrisronline
Copy link
Copy Markdown
Contributor Author

Backport:

6.0: 5d0f154
6.x: f3551a1

@chrisronline chrisronline deleted the remove/get_indices branch August 10, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants