[server/indexPatterns] expose indexPatternService getter/factory#13012
Merged
spalger merged 2 commits intoelastic:masterfrom Jul 31, 2017
Merged
[server/indexPatterns] expose indexPatternService getter/factory#13012spalger merged 2 commits intoelastic:masterfrom
spalger merged 2 commits intoelastic:masterfrom
Conversation
…ex-pattern-factory
Member
|
jenkins, test it |
kimjoar
approved these changes
Jul 31, 2017
Contributor
kimjoar
left a comment
There was a problem hiding this comment.
It doesn't seem like indexPatternsServiceFactory is needed, so unless it's actually used somewhere else I'd prefer it inlined. Otherwise lgtm
tylersmalley
approved these changes
Jul 31, 2017
spalger
added a commit
that referenced
this pull request
Jul 31, 2017
) (cherry picked from commit 9389f0b)
spalger
added a commit
that referenced
this pull request
Jul 31, 2017
) (cherry picked from commit 9389f0b)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While taking a look at https://github.com/elastic/kibana/pull/12611/files#diff-f06ef85a0e4f12fa7cc2f2ff36fe6b19 it became obvious that we needed to properly expose the
IndexPatternsService, so I added:request.getIndexPatternsService()- get anIndexPatternsService()that is configured to make requests to elasticsearch on behalf of this requestserver.indexPatternsServiceFactory({ callCluster })create an instance of theIndexPattermsService()by supplying a customcallClusterfunction (for use outside of request context).