Fix imports from restricted paths#130102
Merged
mbondyra merged 6 commits intoelastic:mainfrom May 3, 2022
Merged
Conversation
alexwizp
reviewed
Apr 15, 2022
| import type { | ||
| EmbeddablePersistableStateService, | ||
| EmbeddableRegistryDefinition, | ||
| } from '../../../embeddable/common'; |
Contributor
There was a problem hiding this comment.
Please let me clarify you some rules:
- If your file placed in
{your_plugin_id}/server/**/*.ts(x)normally we should import from"{plugin}/server". - If your file placed in
{your_plugin_id}/public/**/*.ts(x)normally we should import from"{plugin}/public". - If your file placed in
{your_plugin_id}/common/**/*.ts(x)normally we should import from"{plugin}/common".
About this one. The following import import { EmbeddablePersistableStateService } from '../../../embeddable/common'; was absolutely right and we don't needed to modify that.
Please do re-export needed types from the common folder instead of removing it
# Conflicts: # src/plugins/controls/server/control_group/control_group_container_factory.ts # src/plugins/controls/server/control_types/options_list/options_list_embeddable_factory.ts # src/plugins/controls/server/control_types/time_slider/time_slider_embeddable_factory.ts # src/plugins/dashboard/server/embeddable/dashboard_container_embeddable_factory.ts # src/plugins/embeddable/common/types.ts # src/plugins/embeddable/server/plugin.ts # src/plugins/visualizations/common/types.ts # src/plugins/visualizations/server/embeddable/make_visualize_embeddable_factory.test.ts # src/plugins/visualizations/server/embeddable/make_visualize_embeddable_factory.ts # x-pack/plugins/lens/common/embeddable_factory/index.ts # x-pack/plugins/lens/common/expressions/counter_rate/counter_rate.test.ts # x-pack/plugins/lens/common/expressions/format_column/format_column.test.ts # x-pack/plugins/lens/common/expressions/merge_tables/merge_tables.test.ts # x-pack/plugins/lens/common/expressions/time_scale/time_scale.test.ts # x-pack/plugins/lens/server/embeddable/make_lens_embeddable_factory.ts # x-pack/plugins/lens/server/migrations/saved_object_migrations.ts # x-pack/plugins/lens/server/migrations/types.ts # x-pack/plugins/maps/common/embeddable/extract.ts # x-pack/plugins/maps/common/embeddable/inject.ts
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Contributor
Author
|
@elasticmachine merge upstream |
nreese
approved these changes
Apr 28, 2022
Contributor
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
Contributor
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
vadimkibana
approved these changes
May 3, 2022
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* Fix imports from restricted paths * Re-export EmbeddableRegistryDefinition from embedabble server and fix some imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129316
Summary
EmbeddableRegistryDefinitiontype was moved from embeddable server to common and re-exported from server, which resolved some restricted paths in maps common and didn't affect other imports from server files.For maintainers