Add Elasticsearch Serverless Forwarder to integrations UI by sayden · Pull Request #130085 · elastic/kibana

sayden · 2022-04-13T08:59:18Z

Summary

Add a new tile into the Integrations UI for Elasticsearch Serverless Forwarder for AWS.

I actually have no idea of how to add a new tile so I'm trying to figure it out by grepping here and there for references.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list~~
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

src/plugins/home/server/tutorials/elastic_serverless_forwarder_metrics/index.ts

francescayeye · 2022-04-28T08:06:12Z

@sayden any progress on this?

sayden · 2022-04-28T09:05:07Z

@sayden any progress on this?

Nope, do you want to take it over? If so, happy to help 🙂

src/plugins/custom_integrations/server/placeholders/index.ts

src/plugins/custom_integrations/server/plugin.test.ts

sayden · 2022-05-03T15:02:32Z

@elasticmachine merge upstream

andresrc · 2022-05-10T16:53:19Z

@elasticmachine merge upstream

andresrc · 2022-05-10T16:53:51Z

@elastic/fleet can anyone take a look to this PR? Thanks

nchaulet · 2022-05-10T17:09:29Z

src/plugins/custom_integrations/server/plugin.test.ts

+            'Collect logs using AWS Lambda application available in AWS Serverless Application Repository.',
+          type: 'ui_link',
+          shipper: 'placeholders',
+          uiInternalPath:


I think we probably need to add a new field to the the integration as internal path seems not correct here, uiExternalLink or something like this

I'm glad that you look into this because that's something I would not see myself so clearly in this repo 😅 Let me see 😉

nchaulet · 2022-05-10T17:10:27Z

I am kind of confused by the name placeholder here what do you think of something like externalIntegration or other?

sayden · 2022-05-10T18:50:02Z

I am kind of confused by the name placeholder here what do you think of something like externalIntegration or other?

Yeap! Sounds good!

sayden · 2022-05-11T14:54:39Z

Okay I pushed some changes to add a new field called uiExternalLink and I have done my best attempt into adding the required functionality without touching too much.

But I can still change something if this is not very idiomatic for Kibana or something

Thanks for the help Nicolas 🙂

kibana-ci · 2022-05-11T15:53:56Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`customIntegrations`	79	82	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	704.3KB	704.3KB	+18.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`customIntegrations`	6.2KB	6.2KB	+34.0B

Unknown metric groups

API count

id	before	after	diff
`customIntegrations`	98	101	+3

History

💚 Build #43793 succeeded 0fcc684
💚 Build #42121 succeeded 42a0845
💛 Build #41543 was flaky 96d0f50
💔 Build #41539 failed 91db9b2
💔 Build #41281 failed bc4e1e4
💔 Build #41276 failed 411309a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sayden

nchaulet

Looks good to me 🚀

kibanamachine · 2022-05-11T16:23:51Z

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 130085

Questions ?

Please refer to the Backport tool documentation

francescayeye · 2022-05-31T07:25:18Z

@nchaulet

@ravikesarwani asked if it's possible to backport this to 7.17 (elastic/elastic-serverless-forwarder#100 (comment))

any blocker on Kibana side?

thanks

nchaulet · 2022-05-31T08:39:03Z

I do not think there is any blocker in Kibana side to backport this to 7.17

francescayeye · 2022-06-02T11:52:24Z

great @nchaulet thanks

I will proceed with the manual backport then
what's the backport label that I have to add?

…0085) (cherry picked from commit 34e51a6) # Conflicts: # test/api_integration/apis/custom_integration/integrations.ts

francescayeye · 2022-06-03T08:21:20Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2
✅	7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

) (#133468) * Add Elasticsearch Serverless Forwarder to integrations UI (#130085) (cherry picked from commit 34e51a6) # Conflicts: # test/api_integration/apis/custom_integration/integrations.ts * properly fix conflict * fix import CoreSetup Co-authored-by: Mario Castro <mariocaster@gmail.com>

…0085) (#133477) * Add Elasticsearch Serverless Forwarder to integrations UI (#130085) (cherry picked from commit 34e51a6) # Conflicts: # test/api_integration/apis/custom_integration/integrations.ts * fix import CoreSetup Co-authored-by: Mario Castro <mariocaster@gmail.com>

sayden added the Team:Integrations Team Label for Observability Integrations team label Apr 13, 2022

sayden self-assigned this Apr 13, 2022

sayden mentioned this pull request Apr 13, 2022

SAR: Add Integration tile for elastic-serverless-forwarder in the Integrations UI elastic/elastic-serverless-forwarder#100

Closed

3 tasks

francescayeye reviewed Apr 13, 2022

View reviewed changes

src/plugins/home/server/tutorials/elastic_serverless_forwarder_metrics/index.ts Outdated Show resolved Hide resolved

Add a placeholder "mode" to custom_integrations with tests (I think)

411309a

sayden force-pushed the add_esf_to_integrations_ui branch from 57a7445 to 411309a Compare April 28, 2022 18:55

sayden added 3 commits April 28, 2022 21:15

Fix tests failing in CI

bc4e1e4

Fix jest plugin.test.js test

91db9b2

Fix linting

96d0f50

sayden marked this pull request as ready for review April 29, 2022 23:11

francescayeye reviewed May 2, 2022

View reviewed changes

src/plugins/custom_integrations/server/placeholders/index.ts Outdated Show resolved Hide resolved

src/plugins/custom_integrations/server/plugin.test.ts Outdated Show resolved Hide resolved

sayden added the release_note:skip Skip the PR/issue when compiling release notes label May 3, 2022

Replace destination URL and get rid of the 'replace' function

5178c0a

sayden added the 8.3 candidate label May 3, 2022

Merge branch 'main' into add_esf_to_integrations_ui

42a0845

francescayeye approved these changes May 4, 2022

View reviewed changes

kaiyan-sheng approved these changes May 9, 2022

View reviewed changes

Merge branch 'main' into add_esf_to_integrations_ui

0fcc684

nchaulet reviewed May 10, 2022

View reviewed changes

nchaulet added v8.3.0 and removed 8.3 candidate labels May 10, 2022

Rename component to ExternalIntegration and change field name

692f0dc

sayden requested a review from a team as a code owner May 11, 2022 14:52

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 11, 2022

nchaulet approved these changes May 11, 2022

View reviewed changes

sayden merged commit 34e51a6 into elastic:main May 11, 2022

kibanamachine added the backport:skip This PR does not require backporting label May 11, 2022

sayden added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This PR does not require backporting labels May 11, 2022

kibanamachine added the backport:skip This PR does not require backporting label May 11, 2022

nchaulet added v8.2.0 7.17.5 and removed v8.2.0 labels Jun 2, 2022

francescayeye mentioned this pull request Jun 3, 2022

[8.2] Add Elasticsearch Serverless Forwarder to integrations UI (#130085) #133468

Merged

francescayeye mentioned this pull request Jun 3, 2022

[7.17] Add Elasticsearch Serverless Forwarder to integrations UI (#130085) #133477

Merged

jamiehynds mentioned this pull request Mar 31, 2023

[Integrations] Confluent Cloud integration tile #154173

Closed

Conversation

sayden commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

francescayeye commented Apr 28, 2022

Uh oh!

sayden commented Apr 28, 2022

Uh oh!

Uh oh!

Uh oh!

sayden commented May 3, 2022

Uh oh!

andresrc commented May 10, 2022

Uh oh!

andresrc commented May 10, 2022

Uh oh!

nchaulet May 10, 2022

Choose a reason for hiding this comment

Uh oh!

sayden May 10, 2022

Choose a reason for hiding this comment

Uh oh!

nchaulet commented May 10, 2022

Uh oh!

sayden commented May 10, 2022

Uh oh!

sayden commented May 11, 2022

Uh oh!

kibana-ci commented May 11, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 11, 2022

⚪ Backport skipped

Manual backport

Questions ?

Uh oh!

francescayeye commented May 31, 2022

Uh oh!

nchaulet commented May 31, 2022

Uh oh!

francescayeye commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francescayeye commented Jun 3, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sayden commented Apr 13, 2022 •

edited

Loading

francescayeye commented Jun 2, 2022 •

edited

Loading