[XY] `xyVis` and `layeredXyVis`. by Kuznietsov · Pull Request #128255 · elastic/kibana

Kuznietsov · 2022-03-22T12:38:57Z

Completes #128056 and part of #127115

Changes made:

Will be done in the separate PRs

referenceLineLayer should contain the additional argument for the static value. Otherwise, it is impossible for Canvas' users to use the referenceLineLayer expression via accessors, if they want some static value.
annotationLayers should become usable from Canvas. Now the annotation is not appearing in the chart if used with the other datasource expression function from the one, used in Lens.

Testing notes

layeredXyVis should be tested via Lens. As we've got rid of layerIds at the layeredXyVis, it was required to add some logic of remapping back dataLayer indexes to the layerIds of Lens, as this part of Kibana is tightly coupled with layerIds logic. So, should be checked if all the places, where activeData is used, it was remapped with the Visualization.convertActiveData.
Also, there have been added a lot of checks for the arguments, so, should be tested all the cases with different panel configurations and different series types. Lens must work as before, without errors from the expressions side. As we've got rid of
xyVis should be tested from Canvas with different variations of arguments (starting from zero arguments. The main goal of this PR was to make this expression usable for Canvas' users. It has to guide users on how to use it.). referenceLineLayers and annotationLayers are not usable from Canvas yet.

Example of the expression for the testing in `Canvas`

kibana
| selectFilter
| demodata
| head 10
| xyVis dataLayers={dataLayer xAccessor="project" accessors="price" seriesType="line"}
| render

…to chart_expressions-xy

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

…to chart_expressions-xy

flash1293

Tested around a bit more and couldn't find anything that doesn't work. LGTM!

ppisljar · 2022-04-28T09:28:13Z

src/plugins/expressions/common/execution/execution.ts

-        }
-
        // use an alias if _ is the missing arg
        const errorArg = name === '_' ? aliases[0] : name;


this line has a potential to throw (when aliases is not an array).

const errorArg = name === '_' && aliases?.length ? aliases[0] : name;

I've checked it. name can't have the name _. It should be in aliases. So, in any case, you'll have the first element. Am I wrong?

kibana/src/plugins/expressions/common/expression_functions/expression_function_parameter.ts

Line 30 in e8f59a5

if (name === '_') {

in that case we should get rid of errorArg and just use name

Checked everything. Works as expected. That check was not used.

Kuznietsov · 2022-04-29T06:06:46Z

@elasticmachine merge upstream

mbondyra · 2022-05-02T09:08:09Z

@elasticmachine merge upstream

Kuznietsov · 2022-05-03T07:24:59Z

@elasticmachine merge upstream

kibanamachine · 2022-05-03T07:25:01Z

merge conflict between base and head

…pressions-xy-extended_layers # Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/annotation_layer.ts # src/plugins/chart_expressions/expression_xy/public/components/annotations.tsx # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx # src/plugins/event_annotation/common/index.ts # src/plugins/event_annotation/common/manual_event_annotation/index.ts # src/plugins/event_annotation/common/types.ts # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/annotations_config_panel/index.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/color_picker.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/reference_line_config_panel/reference_line_panel.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/icon_select.tsx # x-pack/plugins/lens/public/xy_visualization/xy_config_panel/shared/marker_decoration_settings.tsx

# Conflicts: # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx

ppisljar

LGTM

…-fix'

kibana-ci · 2022-05-03T14:21:50Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`eventAnnotation`	11	12	+1
`expressionXY`	72	90	+18
`lens`	762	765	+3
total			+22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`eventAnnotation`	87	90	+3
`expressionXY`	463	127	-336
`lens`	452	458	+6
total			-327

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	43.4KB	55.5KB	+12.1KB
`lens`	1.1MB	1.1MB	+696.0B
total			+12.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`expressionXY`	0	13	+13
`kibana`	336	335	-1
`lens`	30	32	+2
total			+14

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`eventAnnotation`	7.2KB	7.5KB	+280.0B
`expressions`	98.9KB	98.8KB	-112.0B
`expressionXY`	24.0KB	27.7KB	+3.8KB
total			+3.9KB

Unknown metric groups

API count

id	before	after	diff
`eventAnnotation`	87	90	+3
`expressionXY`	473	137	-336
`lens`	527	534	+7
total			-326

async chunk count

id	before	after	diff
`expressionXY`	1	5	+4

History

💔 Build #42010 failed 0f4835f
💔 Build #41975 failed b516bb3
💚 Build #41694 succeeded 59ee004
💚 Build #41364 succeeded 320983a
💚 Build #40889 succeeded ac1553b
💚 Build #40846 succeeded 5a1ce2a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

* Added extended layers expressions. * Added support of tables at layers. * Added annotations to layeredXyVIs. * Refactored the implementation to be reusable. * Fixed undefined layers. * Fixed empty arrays problems. * Fixed input translations and removed not used arguments. * Fixed missing required args error, and added required to arguments. * Simplified expression configuration. * Added strict to all the expressions. * Moved dataLayer to the separate component. * Refactored dataLayers helpers and xy_chart. * fillOpacity usage validation is added. * Fixed valueLabels argument options. Removed not used. Added validation for usage. * Added validation to the layeredXyVis. * Fixed extent validation. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com> Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>

jdmcalee · 2023-11-01T13:41:35Z

I apologize for adding this comment now, but I'm trying to understand something. With this change, the ability to scale axes to data bounds was removed for bar charts. Could anyone explain why that was done? My company has several visualizations that became unusable because of that behavior change.

dej611 · 2023-11-01T14:03:31Z

@jdmcalee we're aware of that and looking into fixing it: #170316

Kuznietsov and others added 30 commits March 8, 2022 16:08

added xy plugin.

9388bba

Merge branch 'main' into chart_expressions-xy

8df9659

Added expressionXY limits.

ab72728

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

5747322

…to chart_expressions-xy

Added xy expression functions to the expression_xy plugin.

b4ee9c1

Moved xy to a separate plugin.

400845d

Small refactoring.

b2090f3

Fixed types.

33a06fa

Merge branch 'main' into chart_expressions-xy

d94fa4f

# Conflicts: # src/plugins/chart_expressions/expression_xy/common/expression_functions/legend_config.ts # x-pack/plugins/lens/public/xy_visualization/visualization.tsx

Fixed import of scss.

663e093

Fixed imports.

cbffe77

Added required plugins.

389f933

Fixed import

90aa97a

Fixed types.

1d3a264

Changed expression names.

a78d45d

Fixed bugs, caused by the refactoring process.

35cab91

Merge branch 'main' into chart_expressions-xy

847b3c4

Fixed lens snapshots.

ed7f8ea

Removed new line.

b6daa5d

Merge branch 'chart_expressions-xy' of github.com:Kunzetsov/kibana in…

bda6524

…to chart_expressions-xy

Fixed xy_chart tests.

c8d40fe

Added lazy loading for xy chart.

5fed60c

Fixed xy chart test.

dc195b2

Fixed broken chart selectors.

d39681f

Fixed dashboard tests.

b901d68

dashboard test fixed.

d327dfe

Fixed heatmap vis.

b500961

Smokescreen test fixed.

7a25b74

more fixes.

0004794

async dashboard tests fixed.

fc8c0b3

Kuznietsov added 2 commits April 27, 2022 17:11

Decreased the complexity of the algorithm.

50ec457

Fixed snapshot.

ac1553b

flash1293 approved these changes Apr 28, 2022

View reviewed changes

ppisljar reviewed Apr 28, 2022

View reviewed changes

Merge branch 'main' into chart_expressions-xy-extended_layers

320983a

Merge branch 'main' into chart_expressions-xy-extended_layers

59ee004

mbondyra and others added 6 commits May 3, 2022 09:44

xy_chart.test types

c4b7119

icon type

76c3c78

Merge branch 'main' into chart_expressions-xy-extended_layers

b41f51d

# Conflicts: # src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx

Removed not used check.

2906aef

Replaced an with the.

0f4835f

ppisljar approved these changes May 3, 2022

View reviewed changes

kibanamachine and others added 3 commits May 3, 2022 10:30

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

773ec7f

…-fix'

Fixed tests.

c407547

Merge branch 'main' into chart_expressions-xy-extended_layers

168b032

Kuznietsov merged commit b29b468 into elastic:main May 3, 2022

drewdaemon mentioned this pull request May 3, 2022

[Lens] update default legend size to medium #130336

Merged

2 tasks

Kuznietsov mentioned this pull request May 6, 2022

[Lens] lens_multitable removal. #131699

Merged

mbondyra mentioned this pull request Jun 9, 2022

[Lens] Weird layers behaviour when visualization type is changed for one of them #133933

Closed

dej611 mentioned this pull request Nov 1, 2023

[Agg-based] Custom data bound limited for all xy chart types other than lines #170316

Closed

Conversation

Kuznietsov commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Example of the expression for the testing in Canvas

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Kuznietsov Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

Kuznietsov Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

ppisljar May 3, 2022

Choose a reason for hiding this comment

Uh oh!

Kuznietsov May 3, 2022

Choose a reason for hiding this comment

Uh oh!

Kuznietsov commented Apr 29, 2022

Uh oh!

mbondyra commented May 2, 2022

Uh oh!

Kuznietsov commented May 3, 2022

Uh oh!

kibanamachine commented May 3, 2022

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented May 3, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

History

Uh oh!

jdmcalee commented Nov 1, 2023

Uh oh!

dej611 commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Kuznietsov commented Mar 22, 2022 •

edited

Loading

Example of the expression for the testing in `Canvas`

dej611 commented Nov 1, 2023 •

edited

Loading