Add linting rules for formatting JSX.#12810
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Jul 26, 2017
Merged
Conversation
5477a37 to
8c4ca3b
Compare
kimjoar
approved these changes
Jul 25, 2017
Contributor
kimjoar
left a comment
There was a problem hiding this comment.
These all look sane to me. When merged it would be great if you ship a new version and PR it against both kibana and xpack.
weltenwort
approved these changes
Jul 26, 2017
8c4ca3b to
12405b9
Compare
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 26, 2017
* Add linting rules for formatting JSX. * Bump eslint config version to 0.8.0.
cjcenizal
added a commit
that referenced
this pull request
Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #12725
All rules have been borrowed directly from AirBnB's rules.
Rules added: