Skip to content

visualize should send ready:vis event when done#12796

Merged
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/dashboardSearch
Jul 12, 2017
Merged

visualize should send ready:vis event when done#12796
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/dashboardSearch

Conversation

@ppisljar
Copy link
Copy Markdown
Contributor

closes #12782

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 12, 2017
@ppisljar ppisljar merged commit dee4f7d into elastic:master Jul 12, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 12, 2017
thomasneirynck added a commit that referenced this pull request Jul 12, 2017
This reverts commit dee4f7d.

This needs some more review, as in-tandem with the refresh PR, #12752, it may introduce some unwanted side-effects.
@thomasneirynck
Copy link
Copy Markdown
Contributor

thomasneirynck commented Jul 12, 2017

I reverted this (#12799). I think it caused infinite loops, in tandem with the refresh PR (#12752). Let's look at it closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0-rc1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty search when adding a vis then a search to a dashboard

3 participants