[Maps][File upload] Remove usage of max file size advanced setting 1GB limit in geo file upload#127639
Merged
nreese merged 9 commits intoelastic:mainfrom Mar 16, 2022
Merged
[Maps][File upload] Remove usage of max file size advanced setting 1GB limit in geo file upload#127639nreese merged 9 commits intoelastic:mainfrom
nreese merged 9 commits intoelastic:mainfrom
Conversation
nreese
reviewed
Mar 14, 2022
Contributor
nreese
left a comment
There was a problem hiding this comment.
Can you update the docs to remove from "TIP: When you upload files in {kib}, there is a file size limit, which is configurable in <<fileupload-maxfilesize,Advanced Settings>>." https://github.com/elastic/kibana/blob/main/docs/maps/import-geospatial-data.asciidoc
x-pack/plugins/file_upload/public/components/geo_upload_form/geo_file_picker.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
|
@elasticmachine merge upstream |
nreese
approved these changes
Mar 16, 2022
Contributor
nreese
left a comment
There was a problem hiding this comment.
LGTM
code review, tested in chrome
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
maksimkovalev
added a commit
to maksimkovalev/kibana
that referenced
this pull request
Mar 18, 2022
…B limit in geo file upload (elastic#127639) * elastic#93261 - Usage of maxFileSize in geo upload form is removed * 93261 - refactoring * 93261 - fixed translation checks * 93261 - documentation updates Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #93261
The file size check has been removed for geo file upload form. The message about file size limit has also been removed from geo upload wizard.