Skip to content

[Security Solution] Unskip alerts related Cypress tests#127187

Merged
MadameSheema merged 7 commits intoelastic:mainfrom
MadameSheema:cypress/unskipping-alerts-tests
Mar 10, 2022
Merged

[Security Solution] Unskip alerts related Cypress tests#127187
MadameSheema merged 7 commits intoelastic:mainfrom
MadameSheema:cypress/unskipping-alerts-tests

Conversation

@MadameSheema
Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema commented Mar 8, 2022

Summary

Now that the issue elastic/elasticsearch#84256 has been fixed, we can unskip all the alert related tests.

@MadameSheema MadameSheema requested a review from a team as a code owner March 8, 2022 18:27
@MadameSheema MadameSheema self-assigned this Mar 8, 2022
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team v8.1.1 v8.2.0 labels Mar 8, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2022

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2022

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Mar 8, 2022
jamster10
jamster10 suggested changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jamster10 jamster10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey I had approved it but I think it makes sense to block it until we're sure the tests are flaky rather than theres still a problem

@MadameSheema
Copy link
Copy Markdown
Contributor Author

MadameSheema commented Mar 10, 2022

@elasticmachine merge upstream

@MadameSheema
Copy link
Copy Markdown
Contributor Author

MadameSheema commented Mar 10, 2022

@jamster10 after digging more, I saw that the tests were not flaky, just we needed to update some things in order to align with the current main. i.e. bad locators. If everything works fine, I would deeply appreciate you don't block the PR since it is pretty important to have all the tests back.

@MadameSheema
Copy link
Copy Markdown
Contributor Author

MadameSheema commented Mar 10, 2022

Exceptions tests will remain skipped since it needs more investigation. Those will unskipped in a different PR since we need to have the other tests back to live ASAP.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 10, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 8604a3e into elastic:main Mar 10, 2022
@MadameSheema MadameSheema deleted the cypress/unskipping-alerts-tests branch March 10, 2022 16:11
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 10, 2022

💔 All backports failed

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 127187

Questions ?

Please refer to the Backport tool documentation

MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Mar 10, 2022
@MadameSheema
[Security Solution] Unskip alerts related Cypress tests (elastic#127187)
90b61af 
* unskip tests

* fixing tests

* adding missing lines

* updates locator

* fixes check issues

* keeping exceptions tests skipped since it needs more investigation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8604a3e)

# Conflicts:
#	x-pack/plugins/security_solution/cypress/integration/exceptions/from_alert.spec.ts
#	x-pack/plugins/security_solution/cypress/integration/exceptions/from_rule.spec.ts
#	x-pack/plugins/security_solution/cypress/integration/users/user_details.spec.ts
#	x-pack/plugins/security_solution/cypress/screens/alerts.ts
@MadameSheema MadameSheema mentioned this pull request Mar 10, 2022
Merged
This was referenced Mar 10, 2022
Merged
Merged
MadameSheema added a commit that referenced this pull request Mar 10, 2022
@MadameSheema
[Security Solution] Unskip alerts related Cypress tests (#127187) (#1…
ac5aab4 
…27485)

* unskip tests

* fixing tests

* adding missing lines

* updates locator

* fixes check issues

* keeping exceptions tests skipped since it needs more investigation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8604a3e)

# Conflicts:
#	x-pack/plugins/security_solution/cypress/integration/exceptions/from_alert.spec.ts
#	x-pack/plugins/security_solution/cypress/integration/exceptions/from_rule.spec.ts
#	x-pack/plugins/security_solution/cypress/integration/users/user_details.spec.ts
#	x-pack/plugins/security_solution/cypress/screens/alerts.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamster10 jamster10 jamster10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MadameSheema MadameSheema

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.1.1 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MadameSheema @elasticmachine @kibana-ci @kibanamachine @jamster10