Make filter editor suggestions opt-in#12710
Merged
lukasolson merged 3 commits intoelastic:masterfrom Jul 11, 2017
Merged
Conversation
Bargs
approved these changes
Jul 7, 2017
Contributor
Bargs
left a comment
There was a problem hiding this comment.
Left one minor suggestion. No need to re-review.
| const body = getBody({ | ||
| field, | ||
| include, | ||
| shard_size: 10 |
Contributor
There was a problem hiding this comment.
We should probably include the regular size parameter here as well instead of relying on the default.
| const body = getBody({ field, include }); | ||
| const body = getBody({ | ||
| field, | ||
| include, |
Contributor
There was a problem hiding this comment.
I wonder if this parameter is partly what's hurting us. I don't know how it's implemented, but a regex with a leading wildcard is suspicious. Something to investigate when we try to fix the performance later.
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jul 11, 2017
* Add shard_size to the suggestions terms agg request * Make filter editor suggestions opt-in * Add size parameter
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jul 11, 2017
* Add shard_size to the suggestions terms agg request * Make filter editor suggestions opt-in * Add size parameter
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12692.
With the addition of filter editors, some users with large datasets were experiencing slow queries when using the filter editor autocomplete.
This PR adds a new advanced option,
filterEditor:suggestValues, which defaults to false. When set to false, the filter editor will no longer offer suggestions for values for particular fields. When set to true, however, it will continue to function as it has.In addition, it adds an additional parameter to the terms agg to increase performance:
shard_size. See the docs for more information.