Skip to content

[kbn-pm] Add trailing newline in package.json#125320

Merged
tylersmalley merged 1 commit intoelastic:mainfrom
tylersmalley:newline-package-json
Feb 11, 2022
Merged

[kbn-pm] Add trailing newline in package.json#125320
tylersmalley merged 1 commit intoelastic:mainfrom
tylersmalley:newline-package-json

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Feb 10, 2022

Using yarn add {dependency} adds a newline to the end of package.json. We should match that format.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0 v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 10, 2022
@tylersmalley tylersmalley marked this pull request as ready for review February 10, 2022 22:53
@tylersmalley tylersmalley requested a review from a team as a code owner February 10, 2022 22:53
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley enabled auto-merge (squash) February 10, 2022 23:08
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 643e439 into elastic:main Feb 11, 2022
@tylersmalley tylersmalley deleted the newline-package-json branch February 11, 2022 00:11
@kibanamachine
Copy link
Copy Markdown
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.2.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.0
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
(cherry picked from commit 643e439)

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 11, 2022
(cherry picked from commit 643e439)

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0 v8.1.0 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants