Fix flaky monitor details tests by emilioalvap · Pull Request #124700 · elastic/kibana

emilioalvap · 2022-02-04T15:37:43Z

Summary

Fixes #118476, fixes #122025 & fixes #119770.

Migrate flaky tests to e2e pipeline, together with utility classes and helpers.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

… add monitor details page object

elasticmachine · 2022-02-09T18:04:29Z

Pinging @elastic/uptime (Team:uptime)

emilioalvap · 2022-02-09T18:11:39Z

x-pack/plugins/uptime/e2e/playwright_start.ts


-    listOfJourneys.forEach((journey) => {
-      if (result?.[journey] && result[journey].status !== 'succeeded') {
+    Object.entries(results).forEach(([_journey, result]) => {
+      if (result.status !== 'succeeded') {


Suggesting this one to avoid journeys hardcoded list

emilioalvap · 2022-02-09T18:12:56Z

x-pack/plugins/uptime/e2e/playwright_start.ts


  const res = await playwrightRun({
-    params: { kibanaUrl },
+    params: { kibanaUrl, getService },


Inject kibana services so they can be used in journeys

emilioalvap · 2022-02-10T14:33:12Z

x-pack/plugins/uptime/e2e/page_objects/monitor_management.tsx


    async editMonitor() {
-      await this.clickByTestSubj('monitorManagementEditMonitor');
+      await page.click(this.byTestId('monitorManagementEditMonitor'), { delay: 800 });


I've seen some recordings where clicks on icon buttons are just selecting it, not triggering click action. Adding a click delay seems to fix the issue.

kibana-ci · 2022-02-10T15:58:25Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💔 Build #22885 failed c1ad76a
💔 Build #21871 failed c71ead679ddea8d45d149fbeae2ea0a067bf898d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31

Great work, i do feel the need to have https://playwright.dev/docs/test-parallel in @elastic/synthetics runner now.

Test are taking long time now !!

kibanamachine · 2022-02-23T17:13:05Z

The following labels were identified as gaps in your version labels and will be added automatically:

v8.2.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine · 2022-02-23T17:15:55Z

💔 All backports failed

Status	Branch	Result
❌	8.0	Backport failed because of merge conflicts
❌	8.1	Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 124700

Questions ?

Please refer to the Backport tool documentation

* Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object (cherry picked from commit 453e22e) # Conflicts: # x-pack/plugins/uptime/e2e/journeys/index.ts

* Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object (cherry picked from commit 453e22e) # Conflicts: # x-pack/plugins/uptime/e2e/journeys/index.ts # x-pack/plugins/uptime/e2e/journeys/monitor_management.journey.ts # x-pack/plugins/uptime/e2e/journeys/utils.ts # x-pack/plugins/uptime/e2e/page_objects/monitor_management.tsx # x-pack/plugins/uptime/e2e/playwright_start.ts # x-pack/test/functional_with_es_ssl/apps/uptime/anomaly_alert.ts

kibanamachine · 2022-02-24T17:16:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-02-25T17:26:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-02-28T17:36:17Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-01T17:46:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-02T17:56:20Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-03T18:06:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-04T18:16:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-07T18:26:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-08T18:36:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-09T18:46:17Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

* [Uptime] Fix flaky monitor details tests (#124700) * Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object (cherry picked from commit 453e22e) # Conflicts: # x-pack/plugins/uptime/e2e/journeys/index.ts * adjust tests Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2022-03-10T18:56:19Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-11T19:06:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2022-03-14T15:38:03Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 124700

Questions ?

Please refer to the Backport tool documentation

* Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object (cherry picked from commit 453e22e) # Conflicts: # x-pack/plugins/uptime/e2e/journeys/data_view_permissions.ts # x-pack/plugins/uptime/e2e/journeys/index.ts # x-pack/plugins/uptime/e2e/journeys/monitor_management.journey.ts # x-pack/plugins/uptime/e2e/journeys/uptime.journey.ts # x-pack/plugins/uptime/e2e/journeys/utils.ts # x-pack/plugins/uptime/e2e/page_objects/monitor_management.tsx # x-pack/plugins/uptime/e2e/playwright_start.ts # x-pack/test/functional/apps/uptime/monitor.ts # x-pack/test/functional_with_es_ssl/apps/uptime/anomaly_alert.ts

kibanamachine · 2022-03-15T15:36:18Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

* [Uptime] Fix flaky monitor details tests (#124700) * Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object (cherry picked from commit 453e22e) # Conflicts: # x-pack/plugins/uptime/e2e/journeys/data_view_permissions.ts # x-pack/plugins/uptime/e2e/journeys/index.ts # x-pack/plugins/uptime/e2e/journeys/monitor_management.journey.ts # x-pack/plugins/uptime/e2e/journeys/uptime.journey.ts # x-pack/plugins/uptime/e2e/journeys/utils.ts # x-pack/plugins/uptime/e2e/page_objects/monitor_management.tsx # x-pack/plugins/uptime/e2e/playwright_start.ts # x-pack/test/functional/apps/uptime/monitor.ts # x-pack/test/functional_with_es_ssl/apps/uptime/anomaly_alert.ts * Apply suggestions from code review * update page objects * fix linting * adjust page objects * adjust page objects Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2022-03-16T15:46:19Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

emilioalvap · 2022-03-16T17:04:28Z

Removing backport label as it was merged manually on #127633

emilioalvap added 2 commits February 9, 2022 18:58

Enable flaky suspects

95b1454

Rewrite flaky tests to e2e pipeline, add data initialization helpers,…

c1ad76a

… add monitor details page object

emilioalvap force-pushed the fix-e2e-flaky branch from 3cd3b7f to c1ad76a Compare February 9, 2022 18:00

emilioalvap marked this pull request as ready for review February 9, 2022 18:03

emilioalvap requested a review from a team as a code owner February 9, 2022 18:03

emilioalvap added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.2.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Feb 9, 2022

emilioalvap commented Feb 9, 2022

View reviewed changes

emilioalvap changed the title ~~Enable flaky suspects~~ Fix flaky monitor details tests Feb 9, 2022

Update flaky e2e test

241c4e4

emilioalvap commented Feb 10, 2022

View reviewed changes

emilioalvap added v8.1.0 and removed v8.2.0 labels Feb 10, 2022

shahzad31 approved these changes Feb 11, 2022

View reviewed changes

emilioalvap merged commit 453e22e into elastic:main Feb 11, 2022

kibanamachine added the backport:skip This PR does not require backporting label Feb 11, 2022

dominiqueclarke added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This PR does not require backporting labels Feb 23, 2022

kibanamachine added the v8.2.0 label Feb 23, 2022

dominiqueclarke mentioned this pull request Feb 23, 2022

[8.1] [Uptime] Fix flaky monitor details tests (#124700) #126283

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2022

dominiqueclarke added v7.17.2 auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 14, 2022

dominiqueclarke removed the v8.0.0 label Mar 14, 2022

dominiqueclarke mentioned this pull request Mar 14, 2022

[7.17] [Uptime] Fix flaky monitor details tests (#124700) #127633

Merged

emilioalvap added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 16, 2022

dominiqueclarke mentioned this pull request Mar 21, 2022

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/anomaly_alert·ts - Uptime app with real-world data uptime anomaly alert can open ml flyout #122025

Closed

dominiqueclarke mentioned this pull request Jun 15, 2022

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/anomaly_alert·ts - Uptime app with real-world data uptime anomaly alert has created a valid alert with expected parameters #111667

Closed

Conversation

emilioalvap commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Feb 9, 2022

Uh oh!

emilioalvap Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

emilioalvap Feb 9, 2022

Choose a reason for hiding this comment

Uh oh!

emilioalvap Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Feb 10, 2022

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 23, 2022

Uh oh!

kibanamachine commented Feb 23, 2022

💔 All backports failed

How to fix

Questions ?

Uh oh!

kibanamachine commented Feb 24, 2022

Uh oh!

kibanamachine commented Feb 25, 2022

Uh oh!

kibanamachine commented Feb 28, 2022

Uh oh!

kibanamachine commented Mar 1, 2022

Uh oh!

kibanamachine commented Mar 2, 2022

Uh oh!

kibanamachine commented Mar 3, 2022

Uh oh!

kibanamachine commented Mar 4, 2022

Uh oh!

kibanamachine commented Mar 7, 2022

Uh oh!

kibanamachine commented Mar 8, 2022

Uh oh!

kibanamachine commented Mar 9, 2022

Uh oh!

kibanamachine commented Mar 10, 2022

Uh oh!

kibanamachine commented Mar 11, 2022

Uh oh!

kibanamachine commented Mar 14, 2022

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Mar 15, 2022

Uh oh!

kibanamachine commented Mar 16, 2022

Uh oh!

emilioalvap commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

emilioalvap commented Feb 4, 2022 •

edited

Loading