Conversation
version type support
| private renderParamsEditor() { | ||
| const indexPattern = this.state.selectedIndexPattern; | ||
| if (!indexPattern || !this.state.selectedOperator) { | ||
| if (!indexPattern || !this.state.selectedOperator || !this.state.selectedField) { |
There was a problem hiding this comment.
logically it couldn't happen that we had selectedOperator without a selectedField, but I wanted to clarify this here because children now have field as required
|
|
||
| export function validateParams(params: any, type: string) { | ||
| switch (type) { | ||
| export function validateParams(params: any, field: IFieldType) { |
There was a problem hiding this comment.
because we need to check against field.esTypes now, I am passing the whole field object
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
|
@elasticmachine merge upstream |
|
ACK, will review |
kertal
left a comment
There was a problem hiding this comment.
LGTM, tested a-la-carte, works as expected
Discover isn't consistent in usage. TODO: create issue for discover
Agreed, didn't have time to look into it, so creating an issue is appreciated 👍
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
close #93248
This pr improves support for semantic version field type in Kibana
versionfields to the filter managerversionspecific icon to<FieldIcon/>component (see discussion [EuiIcon] AddtokenVersioneui#5520)Known issues:
versionfield in elasticsearch. I turned it off until it is supported - TODO: link es issue<FieldIcon/>usage. [Discover]<FieldIcon/>usage is inconsistent #124017version#124015How to test
See added functional test
Release notes
Version field type improvements