Skip to content

Azure, GCS, and AWS snapshot repos no longer require plugins#123387

Merged
jrodewig merged 15 commits intoelastic:mainfrom
jrodewig:docs__fix-snapshot-plugins
Jan 25, 2022
Merged

Azure, GCS, and AWS snapshot repos no longer require plugins#123387
jrodewig merged 15 commits intoelastic:mainfrom
jrodewig:docs__fix-snapshot-plugins

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Jan 19, 2022 •
edited
Loading

Summary

With elastic/elasticsearch#81870, the Azure, GCS, and AWS snapshot repository types have built-in support in Elasticsearch and no longer require plugins in 8.0+. This PR updates step one of the Register Repository wizard to:

  • Include Azure, GCS, and AWS as default repository types
  • Tweak UI copy and links referring to repository plugins.

Screenshots

Screen Shot 2022-01-20 at 3 51 57 PM

Testing

As of 20 Jan 2022, the verified ES snapshot doesn't contain changes from elastic/elasticsearch#81870. To test the changes locally, you'll need to use the latest unverified ES snapshot:

KBN_ES_SNAPSHOT_USE_UNVERIFIED=true yarn es snapshot

Checklist

Delete any items that are not applicable to this PR.

@jrodewig jrodewig added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI v8.0.0 v8.1.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Jan 19, 2022
@elastic elastic deleted a comment from kibana-ci Jan 19, 2022
@jrodewig jrodewig marked this pull request as ready for review January 19, 2022 18:35
@jrodewig jrodewig requested review from a team as code owners January 19, 2022 18:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 19, 2022

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@jrodewig jrodewig added the release_note:skip Skip the PR/issue when compiling release notes label Jan 19, 2022
@jrodewig @yuliacech
Update x-pack/plugins/snapshot_restore/server/routes/api/repositories…
f9764cc 
….test.ts

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
@yuliacech
Copy link
Copy Markdown
Contributor

yuliacech commented Jan 20, 2022

Thank you so much for working on this, @jrodewig!
Code changes LGTM 🚀 I'm trying to test locally and getting an error repository type [s3] does not exist. Is there anything specific I need to do when running ES locally for repository types to be enabled?

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 20, 2022 •
edited
Loading

Hi @yuliacech! Thanks for your feedback and review.

Is there anything specific I need to do when running ES locally for repository types to be enabled?

It looks like the verified ES snapshot is a little stale and doesn't contain the changes from elastic/elasticsearch#81870 yet. However, you can use an unverified snapshot with:

KBN_ES_SNAPSHOT_USE_UNVERIFIED=true yarn es snapshot

This snapshot will contain the changes and let you test locally.

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 20, 2022

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibana-ci Jan 20, 2022
@jrodewig jrodewig requested a review from yuliacech January 20, 2022 22:48
@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 24, 2022

@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Jan 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jrodewig! The KBN_ES_SNAPSHOT_USE_UNVERIFIED=true parameter did the trick. Tested locally, everything worked as expected 👍

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 25, 2022

@elasticmachine merge upstream

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 25, 2022

Thanks @yuliacech!

@jrodewig jrodewig enabled auto-merge (squash) January 25, 2022 17:17
@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Jan 25, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jan 25, 2022 •
edited
Loading

💛 Build succeeded, but was flaky

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
snapshotRestore 23 20 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 258.6KB 258.3KB -308.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 291.3KB 291.3KB +19.0B
snapshotRestore 26.7KB 26.7KB -19.0B
total -0.0B
Unknown metric groups

API count

id before after diff
snapshotRestore 23 20 -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jrodewig jrodewig merged commit 1e57604 into elastic:main Jan 25, 2022
@jrodewig jrodewig deleted the docs__fix-snapshot-plugins branch January 25, 2022 22:01
@jrodewig jrodewig mentioned this pull request Jan 25, 2022
Merged
jrodewig added a commit that referenced this pull request Jan 25, 2022
@jrodewig
Azure, GCS, and AWS snapshot repos no longer require plugins (#123387) (
4570443 
#123768)

With elastic/elasticsearch#81870, the Azure, GCS, and AWS snapshot repository types have built-in support in Elasticsearch and no longer require plugins in 8.0+. This PR updates step one of the **Register Repository** wizard to:

- Include Azure, GCS, and AWS as default repository types
- Tweak UI copy and links referring to repository plugins.

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1e57604)

# Conflicts:
#	x-pack/plugins/snapshot_restore/server/routes/api/repositories.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

+1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jrodewig @elasticmachine @yuliacech @kibana-ci @lukeelmers @kibanamachine