Fix autocomplete suggestions for lowercase methods and other related bug#121033
Merged
mibragimov merged 3 commits intoelastic:mainfrom Dec 14, 2021
Merged
Fix autocomplete suggestions for lowercase methods and other related bug#121033mibragimov merged 3 commits intoelastic:mainfrom
mibragimov merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
e2f5074 to
96622e3
Compare
yuliacech
reviewed
Dec 13, 2021
| lastEvaluatedToken.position.column !== currentToken.position.column || | ||
| lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber || | ||
| (lastEvaluatedToken.position.column !== currentToken.position.column || | ||
| lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber) && |
Contributor
There was a problem hiding this comment.
nit: Could you please add a comment here to explain what the boolean expressions do, just to make the code a little easier to understand?
yuliacech
approved these changes
Dec 13, 2021
Contributor
yuliacech
left a comment
There was a problem hiding this comment.
Thank you so much for fixing both bugs, @mibragimov!
Tested locally and all works as expected 👍
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mibragimov |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…bug (elastic#121033) * Fix autocomplete suggestions for lowercase methods and another related bug Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
4 tasks
sakurai-youhei
added a commit
that referenced
this pull request
Aug 23, 2023
## Summary This PR,,, 1. fixes #156254 2. fixes #120606 differently from #121033 3. fixes #19961 differently from #121033 #### [1] left=PR / right=8.9.0  #### [2] left=PR / right=8.9.0  #### [3] left=PR / right=8.9.0  <details> <summary>Original description</summary> 1. fixes #156254 2. refixes #120606 - which should stay closed 3. unfixes #19961 - which must be reopened or duplicated after merging this PR #### [1] left=PR / right=8.9.0  #### [2] left=PR / right=8.9.0  _Autocomplete starts if the method is all uppercase or all lowercase; it doesn't with mixed cases such as `Get`, `gET`, etc. anymore._ #### [3] left=PR / right=8.9.0  _Autocomplete no longer starts on first typing `_` after `url.slash`. No simple solution makes me leave this issue unfixed._ </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Other notes - `backport:skip` because #156254 is not applicable to 7.x. - ~~The release note doesn't need to mention the unfix of #19961 because #121033 mentioned it as `other related bug` only.~~ ### Release note Fixes unnecessary autocompletes on HTTP methods --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #120606, Closes: #19961