[ML] Add Maps ui action to Index data visualizer/Discover's Field statistics#120846
[ML] Add Maps ui action to Index data visualizer/Discover's Field statistics#120846qn895 merged 6 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/ml-ui (:ml) |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
nreese
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding a way to open geo fields in maps.
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest changes and LGTM
|
@elasticmachine merge upstream |
kertal
left a comment
There was a problem hiding this comment.
LGTM, nice and useful addon 👍 , tested and works as expected in Safari, Firefox, Chrome. Just identified a potential cleanup in the code
| JSON.stringify({ | ||
| searchQueryLanguage, | ||
| searchString, | ||
| }, | ||
| actionFlyoutRef | ||
| ); | ||
| if (!Array.isArray(actions) || actions.length < 1) return; | ||
|
|
||
| const actionColumn: EuiTableActionsColumnType<FieldVisConfig> = { | ||
| name: ( | ||
| <FormattedMessage | ||
| id="xpack.dataVisualizer.index.dataGrid.actionsColumnLabel" | ||
| defaultMessage="Actions" | ||
| /> | ||
| ), | ||
| actions, | ||
| width: '100px', | ||
| }; | ||
|
|
||
| return [actionColumn]; | ||
| }, [currentIndexPattern, services, searchQueryLanguage, searchString]); | ||
|
|
||
| }), |
There was a problem hiding this comment.
Just wondering if this is necessary, searchQueryLanguage & searchString are both strings, or am I missing something? so why building an object and then converting it to another string?
There was a problem hiding this comment.
Thanks for catching that 🙏 . The dependency previously includes a query object. I removed this now here 02db5e1
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @qn895 |
…tistics (elastic#120846) * Add map UI actions to dv * Fix maps logo, comment * Add permission check for ui actions * Remove unnecessary json stringify because it no longer includes query object Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR adds the Maps uiAction to Index data visualizer/Discover's Field statistics:
Screen.Recording.2021-12-08.at.15.40.16.mov
Screen.Recording.2021-12-08.at.15.41.42.mov