Use the customMetric's formatter for pipeline aggregations#11933
Use the customMetric's formatter for pipeline aggregations#11933thomasneirynck merged 2 commits intoelastic:masterfrom trevan:formatting-pipeline-aggs
Conversation
|
Can one of the admins verify this patch? |
|
jenkins, test |
|
jenkins, test this |
There was a problem hiding this comment.
When do we hit this code-path? Not a 100% familiar with htis, but don't all parent pipelines require a custom-metric?
There was a problem hiding this comment.
you can also use a predefined one.
ppisljar
left a comment
There was a problem hiding this comment.
LGTM, wanna add a simple test as well ?
thanks a lot trevan!
thomasneirynck
left a comment
There was a problem hiding this comment.
hey trevan, good for me too (in case that wasn't clear), but would be helpful if you can add corresponding test. thx!
|
@ppisljar, @thomasneirynck, sorry it took so long. I finally added tests. |
|
thx! jenkins, test this |
|
CI failing for most obscure of reasons. https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/6095/console jenkins, test this |
|
jenkins, test this |
|
@trevan could you rebase with master, and fix the merge conflict? |
|
I rebased. |
|
jenkins, test this |
|
Thx! |
…1933) This is a manual backport and required edits.
…1933) (elastic#13018) This is a manual backport and required edits.
The pipeline aggregations weren't using the underlying metric's formatter.