Skip to content

[Uptime] Ping redirects - add retry logic#117363

Merged
dominiqueclarke merged 3 commits intoelastic:mainfrom
dominiqueclarke:fix/uptime-ping-redirects-flaky-test
Nov 9, 2021
Merged

[Uptime] Ping redirects - add retry logic#117363
dominiqueclarke merged 3 commits intoelastic:mainfrom
dominiqueclarke:fix/uptime-ping-redirects-flaky-test

Conversation

@dominiqueclarke
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke commented Nov 3, 2021

Summary

Fixes #84992

Adds retry logic to Ping redirects functional tests.

This change was tested in flaky test runner for 42 iterations.

@dominiqueclarke dominiqueclarke added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Nov 8, 2021
@dominiqueclarke dominiqueclarke marked this pull request as ready for review November 8, 2021 17:34
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner November 8, 2021 17:34
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke changed the title add retry logic and focus test [Uptime] Ping redirects - add retry logic Nov 8, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@dominiqueclarke dominiqueclarke merged commit 502db21 into elastic:main Nov 9, 2021
@dominiqueclarke dominiqueclarke deleted the fix/uptime-ping-redirects-flaky-test branch November 9, 2021 14:16
@kibanamachine
Copy link
Copy Markdown
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
* add retry logic and focus test

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
* add retry logic and focus test

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 9, 2021
* add retry logic and focus test

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
kibanamachine added a commit that referenced this pull request Nov 9, 2021
* add retry logic and focus test

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0 v8.1.0

Projects

None yet

4 participants