Skip to content

[SECURITY] Copy saved object flyout should not allow copying into the active space#116657

Merged
XavierM merged 3 commits intoelastic:mainfrom
XavierM:flaky_copy_to_space_flyout_internal
Oct 29, 2021
Merged

[SECURITY] Copy saved object flyout should not allow copying into the active space#116657
XavierM merged 3 commits intoelastic:mainfrom
XavierM:flaky_copy_to_space_flyout_internal

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Oct 28, 2021 •
edited
Loading

Summary

The fly-out should exclude the active space from the list of target spaces. If there are no target spaces, the fly-out should inform you that there are no other spaces to copy this object.

image

I stress out these tests but I was not able to reproduce it, I think the refactor from @jportner made these tests more stable 😍

Resolves: #116650 #96708

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 28, 2021
@XavierM XavierM requested a review from jportner October 28, 2021 14:44
@XavierM XavierM requested a review from a team as a code owner October 28, 2021 14:44
@XavierM XavierM self-assigned this Oct 28, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 28, 2021

Pinging @elastic/kibana-security (Team:Security)

@XavierM
Copy link
Copy Markdown
Contributor Author

XavierM commented Oct 28, 2021

My diligent on the stress: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2111/

jportner
jportner approved these changes Oct 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@jportner jportner linked an issue Oct 28, 2021 that may be closed by this pull request
Failing test: Jest Tests.x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout_internal.test.tsx #96708
Closed
@XavierM
Copy link
Copy Markdown
Contributor Author

XavierM commented Oct 28, 2021

Result from the flakiness suite

image

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 164.6KB 164.6KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @XavierM

@XavierM XavierM changed the base branch from master to main October 29, 2021 14:03
@brianseeders brianseeders changed the base branch from main to master October 29, 2021 15:17
@XavierM XavierM added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 29, 2021
@XavierM XavierM merged commit 3f91556 into elastic:main Oct 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2021
@XavierM @kibanamachine
[SECURITY] Copy saved object flyout should not allow copying into the…
df845a9 
… active space (elastic#116657)

* copy saved object flyout should not allow copying into the active space

* stupid me
@kibanamachine kibanamachine mentioned this pull request Oct 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 29, 2021
@XavierM @kibanamachine
[SECURITY] Copy saved object flyout should not allow copying into the…
3826653 
… active space (elastic#116657)

* copy saved object flyout should not allow copying into the active space

* stupid me
@kibanamachine kibanamachine mentioned this pull request Oct 29, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2021

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 29, 2021
@kibanamachine @XavierM
[SECURITY] Copy saved object flyout should not allow copying into the…
15efa9d 
… active space (#116657) (#116818)

* copy saved object flyout should not allow copying into the active space

* stupid me

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Oct 29, 2021
@kibanamachine @XavierM
[SECURITY] Copy saved object flyout should not allow copying into the…
91b28f3 
… active space (#116657) (#116817)

* copy saved object flyout should not allow copying into the active space

* stupid me

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jportner jportner jportner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@XavierM XavierM

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.16.0 v8.0.0 v8.1.0

Projects

None yet

Milestone

No milestone

4 participants

@XavierM @elasticmachine @kibanamachine @jportner