Improve session timeout deprecation messages.#115020
Merged
azasypkin merged 8 commits intoelastic:7.xfrom Oct 19, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
gchaps
approved these changes
Oct 14, 2021
Contributor
gchaps
left a comment
There was a problem hiding this comment.
LGTM with a minor nit. Is it possible to keep [ms|s|m|h|d|w|M|Y] all on the same line?
Contributor
Author
The only way I could think of is to use a Word Joiner (U+2060) after |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Oct 19, 2021
Contributor
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve session timeout deprecation messages.
Context: #106061 (comment). After a Slack discussion with @gchaps we decided that a documentation link isn't that useful and all required information can be included in the deprecation detailed view instead.
Screenshots