Skip to content

[Security Solution] Fix height issue#114718

Merged
michaelolo24 merged 3 commits intoelastic:masterfrom
michaelolo24:fix-height-issue
Oct 19, 2021
Merged

[Security Solution] Fix height issue#114718
michaelolo24 merged 3 commits intoelastic:masterfrom
michaelolo24:fix-height-issue

Conversation

@michaelolo24
Copy link
Copy Markdown
Contributor

@michaelolo24 michaelolo24 commented Oct 12, 2021 •
edited
Loading

Summary

This issue solves the height problem that is seen when viewing a table with few alerts and the table not adjusting the height to actually show the data. (Usually happens when only 1 - 4ish rows are visible).

We can remove all of this code with this issue being resolved: elastic/eui#5030

@cee-chen
Copy link
Copy Markdown
Contributor

cee-chen commented Oct 15, 2021 •
edited
Loading

I haven't pulled down to QA, but this workaround looks sensible to me until elastic/eui#5030 is addressed of course 🤞

I definitely don't have @chandlerprall's in-depth of knowledge of EuiDataGrid, so if you'd prefer, feel free to wait until he gets back on Monday - but as a heads up it's unlikely we'll be able to prioritize/address 5030 before 7.16 FF, so if this works, I'd say go ahead with it!

@michaelolo24 michaelolo24 marked this pull request as ready for review October 15, 2021 20:32
@michaelolo24 michaelolo24 requested a review from a team as a code owner October 15, 2021 20:32
@michaelolo24 michaelolo24 added auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v7.16.0 v8.0.0 labels Oct 18, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 18, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 18, 2021

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24
Copy link
Copy Markdown
Contributor Author

michaelolo24 commented Oct 18, 2021

@elasticmachine merge upstream

@michaelolo24
Copy link
Copy Markdown
Contributor Author

michaelolo24 commented Oct 18, 2021

@chandlerprall - Do you think we would be able to prioritize the fix of this bug from the EUI side so that we can remove this code before 8.0 release?

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Oct 18, 2021

Do you think we would be able to prioritize the fix of this bug from the EUI side so that we can remove this code before 8.0 release?

Yes, we should be able to land a fix for this before 8.0 FF

@michaelolo24
Copy link
Copy Markdown
Contributor Author

michaelolo24 commented Oct 18, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 18, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 241.4KB 241.4KB +16.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kqualters-elastic
kqualters-elastic approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desk tested locally, height was correct for all settings i tried, and was unable to produce the 0 height issue. lgtm 🚀 👍

@michaelolo24 michaelolo24 merged commit a22066e into elastic:master Oct 19, 2021
@michaelolo24 michaelolo24 deleted the fix-height-issue branch October 19, 2021 20:18
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021
@michaelolo24 @kibanamachine
[Security Solution] Fix height issue (elastic#114718)
f1db32d 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Oct 19, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 19, 2021
@michaelolo24 @kibanamachine
[Security Solution] Fix height issue (elastic#114718)
45f82e3 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Oct 19, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 19, 2021

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 19, 2021
@kibanamachine @michaelolo24
[Security Solution] Fix height issue (#114718) (#115646)
24e0ca9 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 19, 2021
@kibanamachine @michaelolo24
[Security Solution] Fix height issue (#114718) (#115645)
e6b8cd5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
@michaelolo24 michaelolo24 self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@michaelolo24 michaelolo24

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v7.15.2 v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataGrid height doesn't update when rowCount does

6 participants

@michaelolo24 @cee-chen @elasticmachine @chandlerprall @kibanamachine @kqualters-elastic