Skip to content

[Observability] [Exploratory View] Fix calendar cut off, change title, and close accordions on apply changes#113824

Merged
dominiqueclarke merged 4 commits intoelastic:masterfrom
dominiqueclarke:feature/observability-exploratory-view-bug-fixes
Oct 5, 2021
Merged

[Observability] [Exploratory View] Fix calendar cut off, change title, and close accordions on apply changes#113824
dominiqueclarke merged 4 commits intoelastic:masterfrom
dominiqueclarke:feature/observability-exploratory-view-bug-fixes

Conversation

@dominiqueclarke
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke commented Oct 4, 2021

Summary

Fixes elastic/uptime#369 collapse series accordions on apply
Fixes elastic/uptime#370 change title to match figma
Screen Shot 2021-10-04 at 1 46 08 PM
Fixes #113711 fix cut off calendar for series 2+
Screen Shot 2021-10-04 at 1 46 00 PM

Testing calendar cut off

  • The issue only exists on second and subsequent series. Create two or more series, open the accordion for series 2 or up, and click the date range picker. Ensure the calendar is not cut off at any point

Testing close accordions on apply changes

Make any change to any series configuration, then click 'Apply changes'. Ensure that the accordion closes on its own.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 4, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner October 4, 2021 18:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 4, 2021

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 4, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 5, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 352.5KB 352.6KB +128.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic
justinkambic approved these changes Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominiqueclarke dominiqueclarke merged commit 940149c into elastic:master Oct 5, 2021
@dominiqueclarke dominiqueclarke deleted the feature/observability-exploratory-view-bug-fixes branch October 5, 2021 14:18
@dominiqueclarke dominiqueclarke added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 6, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@dominiqueclarke @kibanamachine
[Observability] [Exploratory View] Fix calendar cut off, change title…
1fe732e 
…, and close accordions on apply changes (elastic#113824)

* fix header

* fix calendar is cut off

* close accordions on apply changes

* adjust types
@kibanamachine kibanamachine mentioned this pull request Oct 6, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 6, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
@kibanamachine @dominiqueclarke
[Observability] [Exploratory View] Fix calendar cut off, change title…
fec9d56 
…, and close accordions on apply changes (#113824) (#114153)

* fix header

* fix calendar is cut off

* close accordions on apply changes

* adjust types

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
@dominiqueclarke dominiqueclarke mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@dominiqueclarke @elasticmachine @kibanamachine @justinkambic