[Alerting] Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions#112888
Merged
ymao1 merged 11 commits intoelastic:masterfrom Sep 29, 2021
Merged
[Alerting] Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions#112888ymao1 merged 11 commits intoelastic:masterfrom
ymao1 merged 11 commits intoelastic:masterfrom
Conversation
…-test-saveconfirmation
Contributor
Author
|
@elasticmachine merge upstream |
…-test-saveconfirmation
…-test-saveconfirmation
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts
…-test-saveconfirmation
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
…t/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions (elastic#112888) * Adding delay * Splitting tests * Fixing tests * Reverting change Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
…t/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions (#112888) (#113480) * Adding delay * Splitting tests * Fixing tests * Reverting change Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #85105
Resolves #112749
Summary
The functional test is testing that a save confirmation modal correctly appears when a rule is saved. This part of the test passes correctly. After testing for the existence of the modal and testing for successful save, the test is searching for the newly created rule on the Rule Management page and testing that it shows up. This is the part of the test that is flaky which makes me think that perhaps we're doing it too quickly. Added a short delay before doing this search.
Flaky test runner runs: